Creating unit testing for public methods #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function was returning the opposite of what was intended
AnthonyGriffith
requested review from
Brian06,
KennethCalvo,
alsoto25 and
eric-bv
as code owners
Brian06
reviewed
Sep 12, 2024
| @@ -461,7 +461,7 @@ export class Validation implements FormValidation { | |||
|
|
|||
| if (!this.fieldsToValidate.includes(field)) throw new Error(`Field "${field.name}" is not being validated`); | |||
|
|
|||
| return !!this.validateField(field, silently); | |||
| return !!!this.validateField(field, silently); | |||
There was a problem hiding this comment.
I think this can be: !this.validateField(field, silently);
alsoto25
approved these changes
Sep 12, 2024
Closed
eric-bv
approved these changes
Sep 12, 2024
alsoto25
added a commit
to alsoto25/form-validation-ltv-public
that referenced
this pull request
Oct 29, 2024
commit f640879 Author: Brian Salazar <bsalazarsanchez06@gmail.com> Date: Tue Oct 22 10:32:50 2024 -0600 [SWAT-4099][Form Validation Open Source] Fix in isFieldValid (ltvco#16) * fix to send the correct value * 1.0.2 --------- Co-authored-by: Brian Salazar <briansalazar@Brians-MacBook-Pro.local> commit 4d02934 Author: Brian Salazar <bsalazarsanchez06@gmail.com> Date: Tue Oct 22 09:19:29 2024 -0600 [SWAT-4097] Remove all test related code (ltvco#15) * remove all test related code * remove the fix to apply it in a separate PR --------- Co-authored-by: Brian Salazar <briansalazar@Brians-MacBook-Pro.local> commit a51dfbe Author: Md Mohsin <77264192+Emkay2309@users.noreply.github.com> Date: Tue Oct 15 19:43:24 2024 +0530 Added pull_request_template and created issue templates for bug reports and feature_requests (ltvco#12) commit 643c385 Merge: 4ffcce2 7015f93 Author: Ale Soto <37157321+alsoto25@users.noreply.github.com> Date: Fri Sep 13 12:47:24 2024 -0600 Merge pull request ltvco#11 from AnthonyGriffith/ag_public-methods-tests commit 7015f93 Author: Anthony Griffith <agriffith@ltvco.com> Date: Wed Sep 11 11:42:20 2024 -0600 add tests to all methods commit 282d18c Author: Anthony Griffith <agriffith@ltvco.com> Date: Wed Sep 11 11:40:50 2024 -0600 fix method return the function was returning the opposite of what was intended commit 4ffcce2 Merge: edbc384 157f604 Author: Ale Soto <37157321+alsoto25@users.noreply.github.com> Date: Wed Jul 31 09:55:47 2024 -0600 Merge pull request ltvco#9 from alsoto25/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isFieldValidmethod.Results