Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read latest version in downloads from release data #312

Closed
wants to merge 4 commits into from

Conversation

rollerozxa
Copy link
Member

Simplifies things slightly during release, updating the release data in _data/release.yml will update the downloads page.

_data/release.yml Outdated Show resolved Hide resolved
<a href="https://github.com/minetest/minetest/releases/download/5.9.1/minetest-5.9.1-x86_64.apk">64-bit</a> -
<a href="https://github.com/minetest/minetest/releases/download/5.9.1/minetest-5.9.1-x86.apk">32-bit</a>
<a href="https://github.com/minetest/minetest/releases/download/{{ latest_ver }}/minetest-{{ latest_ver }}-x86_64.apk">64-bit</a> -
<a href="https://github.com/minetest/minetest/releases/download/{{ latest_ver }}/minetest-{{ latest_ver }}-x86.apk">32-bit</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be a problem actually because often the android build is only ready with a delay

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the Android build is made in CI now so there shouldn't be any delay in getting them ready? Any coredev could then sign the APKs when making the release if you've got the keystore password which I assume would be the case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which I assume would be the case

it's not.
also if we get the macos thing working we would have to wait for one specific coredev before we can publish a signed release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that's an issue with the release process that would need some discussion among the core team to give more coredevs access to the keystore password so it doesn't need to fall on one or two coredevs who may be absent during release time, but fair enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@rollerozxa rollerozxa closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants