enable/disable breakpoints from line number

[morgoth990]

My goal is to enable/disable breakpoints from the text editor setting them after lua_load() and keeping them aligned when the script is running.
I see that lua_breakpoint() get a Proto* from the stack and pass it to luaG_breakpoint() but I haven't found a way to get the Proto at a given line or a way to iterate every Proto* in the loaded source.

[zeux]

lua_breakpoint is called on a function object and automatically propagates breakpoints to child functions. As such, the best way for the debugger to use it is to keep the function object that is generated by luau_load by using lua_ref(L, -1) after successful luau_load - this returns a registry index that can be used to query it later.

After that, do something like

lua_getref(L, refidx);
lua_breakpoint(L, -1, line, true);
lua_pop(L, 1);

Note that if you support unloading scripts, you'd want to release the reference by calling lua_unref when you're done with the script, otherwise the function object will permanently stay in memory until the owning state is closed.

[morgoth990]

It's working but I cant disable breakpoints.
Even calling just after breakpoint(true) the breakpoint remain active:

lua_getref(T, mainClosureRef);
lua_breakpoint(T, -1, 4, true);
lua_pop(T, 1);

lua_getref(T, mainClosureRef);
lua_breakpoint(T, -1, 4, false);
lua_pop(T, 1);

Debugging I see that in luaG_breakpoint() at line 319 the op variable is equal LOP_BREAK also when enable is false:
uint8_t op = enable ? LOP_BREAK : LUAU_INSN_OP(p->code[i]);

[zeux]

This line should use p->debuginsn[i] for sure.

[morgoth990]

yes, patching the line seem to work