Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository transfer and reorganization #1074

Closed
zeux opened this issue Oct 16, 2023 · 4 comments
Closed

Repository transfer and reorganization #1074

zeux opened this issue Oct 16, 2023 · 4 comments

Comments

@zeux
Copy link
Collaborator

zeux commented Oct 16, 2023

This issue is an announcement for some upcoming repository changes. They are intended to pave a way for cleaner structure, but they don't change the essence of Luau - Luau continues to be an open-source project which forms a foundation of programming inside Roblox; a team at Roblox is continuously working on making it awesome; it is distributed under the same (MIT) license, will have the same update cadence as before, etc. In short, nothing aside from the GitHub specific repository structure is changing.

Repository transfer

The repository will move into luau-lang org (https://github.com/luau-lang), the name of the repository will stay (luau). This will be done using GitHub repository transfer function; as a result, all existing forks/checkouts should continue to work. All existing issues/PRs should be in tact.

This move will happen on Monday, October 23.

After transfer, git pull for existing checkouts will display warnings with the note that the remote has changed, and recommend adjusting the remote URL. You will need to run something like this to fix the warning (assuming you used SSH checkout):

git remote set-url origin git@github.com:luau-lang/luau

Splitting docs folder into a separate repository

docs folder currently hosts the web site that deploys to https://luau-lang.org/. This folder will be moved to a separate repository in luau-lang organization, called site. The folder will be deleted from this repository with a regular commit; unless you have a PR for docs folder specifically, you should not be affected.

The documentation-only issues will be moved to the new repository. If any unmerged PRs for the site remain, we will close them and expect the author to reopen them against the new repository.

We expect this move to happen the week of October 23-27 and not require any action unless new PRs to docs get opened this week.

Splitting rfcs folder into a separate repository

rfcs folder currently hosts the language proposals. This folder will be moved to a separate repository in luau-lang organization, called rfcs. The folder will be deleted from this repository with a regular commit; unless you have a PR for rfcs folder specifically, you should not be affected.

PRs can not be transferred from a repository to another repository, so they will need to be closed and manually reopened after a transplant vs the new repository. Since RFCs are single-file, we anticipate that it should be easy to fork the new repository and resubmit the changes, linking to the prior discussion if needed. We will not do this ourselves - we will merely close all pending RFCs. We also do not anticipate or recommend blindly re-opening every RFC PR, as most existing PRs have feedback on them that blocks further discussion or approval. We might close some PRs ahead of the move to make the distinction more clear.

Because this is more disruptive as we have a fair amount of RFC PRs opened, we will do this on October 30th.

@zeux zeux pinned this issue Oct 16, 2023
zeux added a commit that referenced this issue Oct 23, 2023
@zeux
Copy link
Collaborator Author

zeux commented Oct 24, 2023

Smertig added a commit to Smertig/rscpp-command-line-test that referenced this issue Oct 24, 2023
* Note, that it's not yet valid at the moment of this commit
* See also: luau-lang/luau#1074
zeux added a commit that referenced this issue Oct 24, 2023
The directory was moved to https://github.com/luau-lang/site

See #1074 for context
@zeux
Copy link
Collaborator Author

zeux commented Oct 24, 2023

The last remaining part of the migration is the RFC move which will happen next week. After this is done we will do some minor README updates to make sure it's obvious where things are.

@zeux zeux changed the title Upcoming repository transfer Repository transfer and reorganization Oct 24, 2023
@zeux
Copy link
Collaborator Author

zeux commented Oct 30, 2023

RFCs have been transferred to a new repository, https://github.com/luau-lang/rfcs (which is now also hosted on https://rfcs.luau-lang.org). The rfcs folder will be deleted from this repository later today.

PRs can not be transferred from a repository to another repository, so they will need to be manually reopened after a transplant vs the new repository. Since RFCs are single-file, we anticipate that it should be easy to fork the new repository and resubmit the changes, linking to the prior discussion if needed. We will not do this ourselves - we will merely close all pending RFCs.

Please note that while it should be easy to reopen an RFC by submitting a new PR against the new repository (if you do so, please link to the previous PR here that was closed if it has any relevant discussion), we do not anticipate or recommend blindly re-opening every RFC PR, as most existing PRs require substantial work on the design for them to be able to be considered.

I will try to briefly summarize possible future steps on each external PR, although please note that since there are a lot of them, my notes will be brief and off the cuff out of necessity, and may not fully represent the scope of work required (and may not be accurate either!). So treat these as an attempt to help think about improving the RFC before resubmitting it instead of specific instructions.

zeux added a commit that referenced this issue Oct 30, 2023
This folder is now hosted in a separate repository https://github.com/luau-lang/rfcs (see #1074 for details)
@zeux
Copy link
Collaborator Author

zeux commented Oct 30, 2023

All open RFCs have been closed with associated notes where applicable; the rfcs folder was deleted. https://github.com/luau-lang/rfcs repository should be used for monitoring or working on RFCs in the future.

This concludes the repository migration and reorganization. Thanks everyone for the patience :)

@zeux zeux closed this as completed Oct 30, 2023
@zeux zeux unpinned this issue Oct 30, 2023
RomanKhafizianov added a commit to RomanKhafizianov/luau that referenced this issue Nov 27, 2023
RomanKhafizianov added a commit to RomanKhafizianov/luau that referenced this issue Nov 27, 2023
This folder is now hosted in a separate repository https://github.com/luau-lang/rfcs (see luau-lang/luau#1074 for details)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant