Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Records #205
RFC: Records #205
Changes from 6 commits
07e5a6f
ed1156a
e0d72ed
dba4276
42b2a4e
aac072b
aa370d9
fa1ad39
a1670da
93e9e9b
ee6c44b
87a3785
7f790d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate subject from records entirely, but the lack of metatable syntax is something we ought to fix, and fairly trivial. Maybe we should just add this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice if
__namecall
is used as it will let you access member methods by indexing on the definition table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the proposal as it exists, you can use pcall et al by doing
pcall(getmetatable(r).Method, r, args)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming
__metatable
can't be overridden then this seems fine to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too awkward, painful, and error prone. If your records are generic, you will have to explicitly spell out the type parameters and then correctly pass these parameters into the type arguments, which is an opportunity for them to be out of order by accident.
While plans around bounded quantification is not being formed at this time, it's possible that you need to duplicate your generic bounds twice, once in your record definition and once again for the same corresponding type parameter in the exported type alias. That's if we decide due to some cases that Luau shouldn't infer generic bounds for explicit generics.
Then there's the matter of scoping,
type Foo = Foo
will circularly reference itself, not the pre-existing type definition.There's two ways I can see out of this:
export record
syntax. It does leave a question of what to do about the record value. We don't have precedent yet about exporting values. Perhaps we should define that first in a separate RFC and have that RFC be a prerequisite for this?export
.