Add lua_isvector, luaL_checkvector and luaL_optvector #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegorov-rbx
approved these changes
Dec 1, 2021
zeux
reviewed
Dec 1, 2021
VM/include/lua.h
Outdated
| @@ -129,6 +129,7 @@ LUA_API int lua_isstring(lua_State* L, int idx); | |||
| LUA_API int lua_iscfunction(lua_State* L, int idx); | |||
| LUA_API int lua_isLfunction(lua_State* L, int idx); | |||
| LUA_API int lua_isuserdata(lua_State* L, int idx); | |||
| LUA_API int lua_isvector(lua_State* L, int idx); | |||
There was a problem hiding this comment.
It might make more sense for this to be a macro that calls lua_type similar to all other "simple" type checks
There was a problem hiding this comment.
You're of course right. Somehow I missed those macros. I'll fix it tomorrow.
There was a problem hiding this comment.
No worries, I fixed this up and switched conformance test to use the new function.
zeux
force-pushed
the
petrih-new-vector-functions
branch
from
0f5800a to
69bacee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.