Sync to upstream/release/549 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vegorov-rbx
commented
Oct 13, 2022
•
vegorov-rbx
commented
- Reoptimized math.min/max/bit32 builtins assuming at least 2 arguments are used (1-2% lift on some benchmarks)
- Type errors that mention function types no longer have redundant parenthesis around return type
- Luau REPL now supports --compile=remarks which displays the source code with optimization remarks embedded as comments
- Builtin calls are slightly faster when called with 1-2 arguments (~1% improvement in some benchmarks)
This exposes a bug in CodeAllocator that needs to be fixed properly
zeux
reviewed
Oct 14, 2022
CodeGen/src/NativeState.cpp
Outdated
| @@ -94,7 +94,7 @@ void initHelperFunctions(NativeState& data) | |||
| "fast call tables are not of the same length"); | |||
|
|
|||
| // Replace missing fast call functions with an empty placeholder that forces LOP_CALL fallback | |||
| for (int i = 0; i < sizeof(data.context.luauF_table) / sizeof(data.context.luauF_table[0]); i++) | |||
| for (int i = 0; i < int(sizeof(data.context.luauF_table) / sizeof(data.context.luauF_table[0])); i++) | |||
|
A couple missing notes:
|
Added, thank you. |
zeux
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.