Fix string interpolation autocomplete and location #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I want to test first is that something like |
vegorov-rbx
reviewed
Nov 16, 2022
| @@ -2706,14 +2728,18 @@ AstExpr* Parser::parseInterpString() | |||
| break; | |||
| case Lexeme::BrokenInterpDoubleBrace: | |||
| nextLexeme(); | |||
| return reportExprError(location, {}, ERROR_INVALID_INTERP_DOUBLE_BRACE); | |||
| return reportExprError(endLocation, {}, ERROR_INVALID_INTERP_DOUBLE_BRACE); | |||
There was a problem hiding this comment.
nit: note for some future clean-up PR, constant should have been a static const char* kErrorInvalidInterpDoubleBrace = ; instead of a define.
There was a problem hiding this comment.
For whatever reason, that didn't work when I tried it.
https://github.com/Roblox/luau/pull/614/files#r931152226
There was a problem hiding this comment.
Another work-around would be reportExprError(endLocation, {}, "%s", kErrorInvalidInterpDoubleBrace); but doesn't matter any more.
vegorov-rbx
approved these changes
Nov 16, 2022
|
Should be ready for merge 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String interpolation autocomplete was not working and was just using default autocomplete. This fixes it so that inside a string it is treated as normal, and inside an expression it suggests expression level autocomplete.
Also fixes the range, which was previously just the first lexeme.