Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News about string interpolation feature and a syntax page update #829

Merged
merged 13 commits into from
Feb 3, 2023

Conversation

vegorov-rbx
Copy link
Collaborator

News can be viewed here
And syntax can be viewed here

Note that link appears to be broken in the news section. It goes to https://vegorov-rbx.github.io/syntax#string-interpolation instead of https://vegorov-rbx.github.io/luau/syntax#string-interpolation
The link I use in the source is /syntax#string-interpolation but the root 'offset' is different on Luau website (doesn't have extra 'luau' folder) and on my GitHub pages.
Hope this is ok. But if GitHub page masters know how to avoid this, please let me know.

Copy link
Collaborator

@asajeffrey asajeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

docs/_posts/2023-02-02-luau-string-interpolation.md Outdated Show resolved Hide resolved
docs/_posts/2023-02-02-luau-string-interpolation.md Outdated Show resolved Hide resolved
docs/_pages/syntax.md Outdated Show resolved Hide resolved
Co-authored-by: Alan Jeffrey <403333+asajeffrey@users.noreply.github.com>
@vegorov-rbx
Copy link
Collaborator Author

Minor nits.

Thank you!

Copy link
Contributor

@alexmccord alexmccord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nits, using double backticks with a space after it will remove the space at the end.

docs/_pages/syntax.md Outdated Show resolved Hide resolved
docs/_pages/syntax.md Outdated Show resolved Hide resolved
docs/_pages/syntax.md Outdated Show resolved Hide resolved
vegorov-rbx and others added 4 commits February 3, 2023 11:08
Co-authored-by: Alexander McCord <11488393+alexmccord@users.noreply.github.com>
Co-authored-by: Alexander McCord <11488393+alexmccord@users.noreply.github.com>
@vegorov-rbx vegorov-rbx merged commit c5555c6 into luau-lang:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants