-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News about string interpolation feature and a syntax page update #829
Merged
vegorov-rbx
merged 13 commits into
luau-lang:master
from
vegorov-rbx:string-interpolation-news
Feb 3, 2023
Merged
News about string interpolation feature and a syntax page update #829
vegorov-rbx
merged 13 commits into
luau-lang:master
from
vegorov-rbx:string-interpolation-news
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asajeffrey
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits.
Co-authored-by: Alan Jeffrey <403333+asajeffrey@users.noreply.github.com>
Thank you! |
asajeffrey
approved these changes
Feb 3, 2023
alexmccord
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nits, using double backticks with a space after it will remove the space at the end.
Co-authored-by: Alexander McCord <11488393+alexmccord@users.noreply.github.com>
Co-authored-by: Alexander McCord <11488393+alexmccord@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News can be viewed here
And syntax can be viewed here
Note that link appears to be broken in the news section. It goes to
https://vegorov-rbx.github.io/syntax#string-interpolation
instead ofhttps://vegorov-rbx.github.io/luau/syntax#string-interpolation
The link I use in the source is
/syntax#string-interpolation
but the root 'offset' is different on Luau website (doesn't have extra 'luau' folder) and on my GitHub pages.Hope this is ok. But if GitHub page masters know how to avoid this, please let me know.