Remove -march for riscv #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #283 +/- ##
============================================
- Coverage 59.88% 59.74% -0.15%
+ Complexity 302 301 -1
============================================
Files 26 26
Lines 1421 1421
Branches 164 164
============================================
- Hits 851 849 -2
- Misses 416 417 +1
- Partials 154 155 +1 |
|
LGTM |
|
Thanks for your reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Can you review this simple change?
It removes the
-marchargument when cross-compile riscv in make_so_cross.sh. This is to let the compiler to pick up the default arch, to enable most compatability on different hardwares.Thanks!