Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to look for disambiguations on Wikidata #1

Open
lubianat opened this issue Apr 4, 2022 · 2 comments
Open

Add logic to look for disambiguations on Wikidata #1

lubianat opened this issue Apr 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@lubianat
Copy link
Owner

lubianat commented Apr 4, 2022

e.g. :

"organization": {
                        "name": "University of Regensburg",
                        "address": {
                            "city": "Regensburg",
                            "region": "Bayern",
                            "country": "DE"
                        },
                        "disambiguated-organization": {
                            "disambiguated-organization-identifier": "grid.7727.5",
                            "disambiguation-source": "GRID"
                        }
                    }

code should look up id on Wikidata before asking user for key

jvfe added a commit to jvfe/pyorcidator that referenced this issue Apr 6, 2022
Adds a simple lookup for an unknown term before asking the user for a
prompt.

Uses the wikibase/wikidata API for an entity search

Could be made more efficient:
- Tackle requests of all unknown keys at once with async code

* Addresses lubianat#1
@jvfe
Copy link
Collaborator

jvfe commented Apr 6, 2022

Oh I think I misunderstood this in #5. I thought of general disambiguation initially - by name. But this is referring to P2427. My apologies! Either way I still think #5 is a worthwhile addition.

@lubianat
Copy link
Owner Author

lubianat commented Apr 6, 2022

Actually there are several IDs that ORCID uses (so not always P2427); nevertheless it is good to have a default to just type through

@jvfe jvfe added the enhancement New feature or request label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants