How-to customize template.js and fully leverages dockerode with customizable connect text #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, thank you for taking part in this project! The changes you made look promising. I'll try to test them over the next few days. |
luc-ass
added
enhancement
luc-ass
approved these changes
Dec 13, 2024
|
I'll merge it into the current development branch. Let's see how it goes ;) |
@luc-ass seems to work - tested with Connection info I get via Telegram Bot message: |
|
Same here! Great addition! |
|
All looked good. I released 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
template.jsmessages, including available event variablesdockeroderequire('os')as data is part ofdockerodealready (see above point)template.jsREMARKS
Unfortunately I am not able to test these changes, so would appreciate if someone could do so before merging.
Also I am not really familiar with node.js development, and mostly did the changes by adapting to the existing code, with help of the official Docker Engine API and dockerode documentations.