Support Domestic Hot Water #143

georgesdib · 2023-02-18T12:50:43Z

Added 2 HomeKit accessories, a temperature sensor and a switch to support Evohome Domestic Hot Water.

Also added history logging for Eve.

Changed the behaviour of the valve for the thermostat to be 100% when it's heating and 0% when it's not.

Fixes #80

Code cleanup

SeaneyC · 2023-02-18T12:56:17Z

Whoa nice updates! I’ll give it a look when I can, I have a tank/circuit. Many thanks all!

…

On Sat, 18 Feb 2023 at 12:50, Georges ***@***.***> wrote: Added 2 HomeKit accessory, a temperature sensor and a switch to support Evohome Domestic Hot Water. Also added history logging for Eve. Changed the behaviour of the valve for the thermostat to be 100% when it's heating and 0% when it's not. ------------------------------ You can view, comment on, or merge this pull request online at: #143 Commit Summary - ccd2d04 <ccd2d04> Beginning to support Hot Water - b9dcc02 <b9dcc02> Fixing when there is no hot water - f0dbff9 <f0dbff9> Adding HotWater switch accessory - 0ce1f49 <0ce1f49> Adding Hot Water switch controls - b4ee936 <b4ee936> Temporary and not permanenet override. - 2c93efb <2c93efb> Revamp of the full structure - ac95608 <ac95608> Override until next schedule - 79ca431 <79ca431> Changing the accessory type to sensor and switch - df425d1 <df425d1> Adding logging for the hot water temperature - 9732477 <9732477> Valve position is open if temp < target - 342a761 <342a761> Better temperature refresh for hot water - 479161a <479161a> better default value - cd16e04 <cd16e04> fixing a typo - 974a96d <974a96d> update state when set File Changes (2 files <https://github.com/luc-ass/homebridge-evohome/pull/143/files>) - *M* index.js <https://github.com/luc-ass/homebridge-evohome/pull/143/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346> (485) - *M* lib/evohome.js <https://github.com/luc-ass/homebridge-evohome/pull/143/files#diff-4bef5d90c26fce65a706defc933448b512744410d5a4100948599c980e310fe1> (53) Patch Links: - https://github.com/luc-ass/homebridge-evohome/pull/143.patch - https://github.com/luc-ass/homebridge-evohome/pull/143.diff — Reply to this email directly, view it on GitHub <#143>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT4A6BPRIM6QVMBXOE6J2FDWYDAS7ANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

5xPa · 2023-02-18T15:10:29Z

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

georgesdib · 2023-02-18T15:23:00Z

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water?

5xPa · 2023-02-18T15:48:43Z

Hi Yes I have evohome control of hotwater tank Here is a copy of the log as Evohome connects [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child bridge successfully [18/02/2023, 15:00:15] Loaded 0 cached accessories from cachedAccessories.0E3B232C36DD. [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will be using Index No 0 [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time to load and preventing Homebridge from starting. See https://homebridge.io/w/JtMGR for more info. [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Garage Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom Mode'... [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running on port 56862. [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received

…

On Sat, 18 Feb 2023 at 15:23, Georges ***@***.***> wrote: Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable? After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water? — Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you commented.Message ID: ***@***.***>

SeaneyC · 2023-02-18T15:51:12Z

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated?

…

On Sat, 18 Feb 2023 at 15:48, 5xPa ***@***.***> wrote: Hi Yes I have evohome control of hotwater tank Here is a copy of the log as Evohome connects [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child bridge successfully [18/02/2023, 15:00:15] Loaded 0 cached accessories from cachedAccessories.0E3B232C36DD. [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will be using Index No 0 [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time to load and preventing Homebridge from starting. See https://homebridge.io/w/JtMGR for more info. [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Garage Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom Mode'... [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running on port 56862. [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received On Sat, 18 Feb 2023 at 15:23, Georges ***@***.***> wrote: > Have applied the update, I don't see anything to do with the Hotwater > system. Is there something I need to enable? > > After I updated the code, I just went to my home app and I could see the > hot water temperature sensor and switch. Are you not able to see that at > all? Not to state the obvious, but you are using it on a location that has > hot water? > > — > Reply to this email directly, view it on GitHub > < #143 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I > > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT4A6BPMCFHD64ATH2UOHX3WYDVOLANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you commented.Message ID: ***@***.***>

georgesdib · 2023-02-18T15:54:53Z

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated?
…

That is correct, it has not been merged to main yet.
@5xPa are you using the official plugin from homebridge? If so, then indeed, it won't be there yet. You need to use this branch's code to have it.

5xPa · 2023-02-18T16:12:10Z

Hi Thanks for the reply, I just went into Homebridge and selected update to homebridge-evohome v0.10.2 I don't know how to update any other way.

…

On Sat, 18 Feb 2023 at 15:51, SeaneyC ***@***.***> wrote: Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated? On Sat, 18 Feb 2023 at 15:48, 5xPa ***@***.***> wrote: > Hi Yes I have evohome control of hotwater tank > > Here is a copy of the log as Evohome connects > [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child > bridge successfully > [18/02/2023, 15:00:15] Loaded 0 cached accessories from > cachedAccessories.0E3B232C36DD. > [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... > [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! > [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will > be using Index No 0 > [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). > [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time > to load and preventing Homebridge from starting. See > https://homebridge.io/w/JtMGR for more info. > [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) > [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) > [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) > [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) > [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) > [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) > [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) > [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) > [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) > [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) > [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room > Thermostat'... > [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room > Thermostat'... > [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Garage > Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away > Mode'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off > Mode'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off > Mode'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco > Mode'... > [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom > Mode'... > [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running > on port 56862. > [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. > [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received > > On Sat, 18 Feb 2023 at 15:23, Georges ***@***.***> wrote: > > > Have applied the update, I don't see anything to do with the Hotwater > > system. Is there something I need to enable? > > > > After I updated the code, I just went to my home app and I could see the > > hot water temperature sensor and switch. Are you not able to see that at > > all? Not to state the obvious, but you are using it on a location that > has > > hot water? > > > > — > > Reply to this email directly, view it on GitHub > > < > #143 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I > > > > . > > You are receiving this because you commented.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > < #143 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AT4A6BPMCFHD64ATH2UOHX3WYDVOLANCNFSM6AAAAAAVAKSA6I > > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARF3VCGBMWGYOUTC2LIUU6DWYDVXXANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you commented.Message ID: ***@***.***>

5xPa · 2023-02-18T16:13:00Z

How do I i?nstall a branch

…

On Sat, 18 Feb 2023 at 15:55, Georges ***@***.***> wrote: Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated? … <#m_-8301007509611088718_> That is correct, it has not been merged to main yet. @5xPa <https://github.com/5xPa> are you using the official plugin from homebridge? If so, then indeed, it won't be there yet. You need to use this branch's code to have it. — Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARF3VCH3G2GKTCWDHO6JM4DWYDWFRANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you were mentioned.Message ID: ***@***.***>

georgesdib · 2023-02-18T16:51:01Z

How do I i?nstall a branch
…

I would strongly advise running a second homebridge for that to not mess up with your production setup. If you don't feel comfortable for that, I would say don't test it yet.

Otherwise, if you have a separate homebridge running, you need to find where the plugins are installed, and override the homebridge-evohome files by the ones here and then restart homebridge (or only the sub bridge if you are running a sub bridge).

5xPa · 2023-02-18T17:13:54Z

Hi Thanks for the replies, I shall do as you advise and wait until the standard version has hotwater control

…

On Sat, 18 Feb 2023 at 16:51, Georges ***@***.***> wrote: How do I i?nstall a branch … <#m_875641225860886518_> I would strongly advise running a second homebridge for that to not mess up with your production setup. If you don't feel comfortable for that, I would say don't test it yet. Otherwise, if you have a separate homebridge running, you need to find where the plugins are installed, and override the homebridge-evohome files by the ones here and then restart homebridge (or only the sub bridge if you are running a sub bridge). — Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARF3VCHYB6XILOLXIUPROKDWYD4YBANCNFSM6AAAAAAVAKSA6I> . You are receiving this because you were mentioned.Message ID: ***@***.***>

luc-ass · 2023-02-20T21:21:48Z

Hey there. This is awesome news!! As I do not have the hot water unit I have not way of testing. How long have you been running it? Is it stable?

georgesdib · 2023-02-20T21:27:12Z

Hey there. This is awesome news!! As I do not have the hot water unit I have not way of testing. How long have you been running it? Is it stable?

I have been running it for a couple of weeks now, seems pretty stable to me yes.
Please note I also changed the way the valve for a regular thermostat reports (instead of hardcoding to 50%, make it 100 or 0 based on if targetTemp >= currentTemp

luc-ass · 2023-02-20T21:34:14Z

Great! I'll review the changes in the coming days and merge it back into the project. Thank you so much for your hard work!

luc-ass · 2023-03-01T05:08:24Z

LGTM, will test it over the weekend

luc-ass

LGTM

luc-ass · 2023-03-09T15:06:41Z

@georgesdib I've released your additions and fixes as v0.11.0. Thank you!! 🚀

5xPa · 2023-03-09T16:31:49Z

Brilliant can now view Hotwater in HomeKit. Thanks for all the effort

Georges Dib added 14 commits February 10, 2023 13:57

Beginning to support Hot Water

ccd2d04

Fixing when there is no hot water

b9dcc02

Adding HotWater switch accessory

f0dbff9

Adding Hot Water switch controls

0ce1f49

Temporary and not permanenet override.

b4ee936

Code cleanup

Revamp of the full structure

2c93efb

Override until next schedule

ac95608

Changing the accessory type to sensor and switch

79ca431

Adding logging for the hot water temperature

df425d1

Valve position is open if temp < target

9732477

Better temperature refresh for hot water

342a761

better default value

479161a

fixing a typo

cd16e04

update state when set

974a96d

luc-ass self-requested a review February 20, 2023 21:34

luc-ass added the enhancement label Feb 20, 2023

georgesdib mentioned this pull request Feb 28, 2023

temperatureAboveAsOff not working #139

Closed

luc-ass merged commit 0f32f06 into luc-ass:master Mar 9, 2023

luc-ass reviewed Mar 9, 2023

View reviewed changes

georgesdib deleted the valve-history branch March 9, 2023 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Domestic Hot Water #143

Support Domestic Hot Water #143

georgesdib commented Feb 18, 2023 •

edited

Loading

SeaneyC commented Feb 18, 2023 via email

5xPa commented Feb 18, 2023

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

SeaneyC commented Feb 18, 2023 via email

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

5xPa commented Feb 18, 2023 via email

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

luc-ass commented Feb 20, 2023

georgesdib commented Feb 20, 2023

luc-ass commented Feb 20, 2023

luc-ass commented Mar 1, 2023

luc-ass left a comment

luc-ass commented Mar 9, 2023

5xPa commented Mar 9, 2023

Support Domestic Hot Water #143

Support Domestic Hot Water #143

Conversation

georgesdib commented Feb 18, 2023 • edited Loading

SeaneyC commented Feb 18, 2023 via email

5xPa commented Feb 18, 2023

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

SeaneyC commented Feb 18, 2023 via email

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

5xPa commented Feb 18, 2023 via email

georgesdib commented Feb 18, 2023

5xPa commented Feb 18, 2023 via email

luc-ass commented Feb 20, 2023

georgesdib commented Feb 20, 2023

luc-ass commented Feb 20, 2023

luc-ass commented Mar 1, 2023

luc-ass left a comment

Choose a reason for hiding this comment

luc-ass commented Mar 9, 2023

5xPa commented Mar 9, 2023

georgesdib commented Feb 18, 2023 •

edited

Loading