Enable the flag incompatible_disallow_hashing_frozen_mutables

Fixes bazelbuild/bazel#7800 RELNOTES: The flag incompatible_disallow_hashing_frozen_mutables is enabled (bazelbuild/bazel#7800) PiperOrigin-RevId: 264659899
luca-digrazia · Sep 4, 2022 · 026b475 · 026b475
1 parent fc91297
commit 026b475
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/....bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/....bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -499,7 +499,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
 
   @Option(
       name = "incompatible_no_target_output_group",
-      defaultValue = "true",
+      defaultValue = "false",
       documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
       effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
       metadataTags = {

diff --git a/...azelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/...azelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -271,7 +271,7 @@ public static Builder builderWithDefaults() {
           .incompatibleNoOutputAttrDefault(true)
           .incompatibleNoRuleOutputsParam(false)
           .incompatibleNoSupportToolsInActionInputs(true)
-          .incompatibleNoTargetOutputGroup(true)
+          .incompatibleNoTargetOutputGroup(false)
           .incompatibleNoTransitiveLoads(true)
           .incompatibleObjcFrameworkCleanup(true)
           .incompatibleRemapMainRepo(false)

diff --git a/...azel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java b/...azel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java
@@ -494,22 +494,6 @@ public void configKeyNonexistentTarget() throws Exception {
     assertContainsEvent("//foo:fake is not a valid configuration key for //foo:g");
   }
 
-  @Test
-  public void configKeyNonexistentTarget_otherPackage() throws Exception {
-    reporter.removeHandler(failFastHandler); // Expect errors.
-    scratch.file("bar/BUILD");
-    scratch.file(
-        "foo/BUILD",
-        "genrule(",
-        "    name = 'g',",
-        "    outs = ['g.out'],",
-        "    cmd = select({'//bar:fake': ''})",
-        ")");
-    assertThat(getConfiguredTarget("//foo:g")).isNull();
-    assertContainsEvent(
-        "While resolving configuation keys for //foo:g: no such target '//bar:fake'");
-  }
-
   /**
    * Tests config keys with multiple requirements.
    */