Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credentials: add helpers for accessing credential data #120

Merged
merged 1 commit into from
Nov 4, 2022
Merged

credentials: add helpers for accessing credential data #120

merged 1 commit into from
Nov 4, 2022

Conversation

lucab
Copy link
Owner

@lucab lucab commented Oct 21, 2022

See #98 for the original code/discussion behind this.

@lucab lucab requested a review from swsnr October 25, 2022 07:59
swsnr
swsnr reviewed Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel that this is too trivial to abstract over, but if you consider this a valuable interface let's go ahead.

I did have a few remarks wrt to error handling which I'd like to discuss 🙂

src/credentials.rs Show resolved Hide resolved
src/credentials.rs Show resolved Hide resolved
src/credentials.rs Show resolved Hide resolved
src/credentials.rs Show resolved Hide resolved
@lucab lucab merged commit 8ada6e3 into master Nov 4, 2022
@lucab lucab deleted the ups/credentials branch November 4, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swsnr swsnr swsnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucab @swsnr @vilgotf