Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on platforms with variants #27

Open
zinen opened this issue Mar 13, 2023 · 3 comments · May be fixed by #29
Open

Fails on platforms with variants #27

zinen opened this issue Mar 13, 2023 · 3 comments · May be fixed by #29

Comments

@zinen
Copy link

zinen commented Mar 13, 2023

I tried a lot of stuff that ended with an UNAUTHORIZED response from the docker API.

Some troubleshooting let me to that this error is gone if I remove the platforms with variants. E.g. removing linux/arm/v6 and linux/arm/v7 from the platforms input.

My code that fails:

jobs:
  get-docker-version:
    runs-on: ubuntu-latest
    steps:
      - name: Docker Image Update Checker
        id: check
        uses: lucacome/docker-image-update-checker@v1.2.1
        with:
          base-image: alpine:latest
          image: zinen2/alpine-pigpiod:latest
          platforms: linux/arm/v6,linux/arm/v7,linux/arm64
          # platforms: linux/arm64
        env:
          DEBUG: true
@clowa
Copy link

clowa commented Mar 23, 2023

Hey @zinen, I run into a similar issue and created a fork to fix this issue. It's a bit tricky since the variant seams to be optional eg. linux/arm64 and linux/arm64/v8 means the same architecture. I have tested my new version with some of my repositories and it looks quite good. Would be great to know if my changes would also fix your issue - could you try it out by changing the action to clowa/docker-image-update-checker@342608bb9829d85eeeeb292e78115184b5a6657d ? Let me know if this fixes your issue too, then I will create a PR.

@zinen
Copy link
Author

zinen commented Mar 24, 2023

Tried this with clowa/docker-image-update-checker@342608bb9829d85eeeeb292e78115184b5a6657d and platforms: linux/arm/v6,linux/arm/v7,linux/arm64 and it did not throw an error. The logs from DEBUG: true indicated that your fork successfully loops the variants of my images and compares back to the base-image.

I think maybe you solved this.

@clowa clowa linked a pull request Mar 24, 2023 that will close this issue
@dersimn
Copy link

dersimn commented Sep 12, 2023

Works with your fork (clowa/docker-image-update-checker@cebb3edee1fc9ed36c1526c23c784998c7ac2d75, the sha from previous comments isn't valid anymore), however..

Base Images from library seem to use linux/arm64/v8 as platform, when I build images on my own the v8 get's removed by Docker Build for whatever reason.

library/alpine 3:

image

dersimn/github-actions-to-docker-hub-simple, using this workflow:

image

This still fails with error Error: Platform linux/arm64/v8 not found in the image dersimn/github-actions-to-docker-hub-simple.

dersimn added a commit to dersimn/GitHub-Actions-to-Docker-Hub-simple that referenced this issue Sep 12, 2023
dersimn added a commit to dersimn/GitHub-Actions-to-Docker-Hub-with-multiple-Flavors that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants