Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to compare platform variants #29

Open
wants to merge 8 commits into
base: release-1.0
Choose a base branch
from
Open

Add support to compare platform variants #29

wants to merge 8 commits into from

Conversation

clowa
Copy link

@clowa clowa commented Mar 24, 2023 •
edited

Add support to optionally compare image platform variants. Eg. linux/arm64 is equal to linux/arm64/v8 and both are heavily used on docker images.

This fixes #27 ✅

@lucacome let me know what you think 📩

Changes ⚙️

  • independently parse platforms with and without variants from image manifest
  • compare platforms against all allowed platform notations. Eg. linux/arm64 is equal to linux/arm64/v8

@clowa clowa force-pushed the issue/multi-platform-variant branch from 5482a7a to d2c894b Compare March 24, 2023 11:24
@clowa clowa marked this pull request as ready for review March 24, 2023 11:55
@lucacome lucacome changed the base branch from main to release-1.0 April 11, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails on platforms with variants
2 participants
@clowa @lucacome