Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: increase bash robustness #10

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

Entepotenz
Copy link
Contributor

Hi,

I have a couple of improvements to increase the robustness of the shell script :-)

@lucacome
Copy link
Owner

lucacome commented Jan 5, 2023

Hi @Entepotenz thanks for the PRs! I've added triggers for the CI to run on PRs as well so we can make sure everything still works 🙂 if you rebase your PR it should bring those changes in

Copy link
Owner

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lucacome lucacome merged commit 463f1f9 into lucacome:main Jan 5, 2023
@lucacome lucacome added the enhancement New feature or request label Jan 5, 2023
@Entepotenz
Copy link
Contributor Author

you are welcome :-)

@Entepotenz Entepotenz deleted the increase_bash_robustness branch January 6, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants