Automatically detect if prefix library/ is needed
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entepotenz
force-pushed
the
handle_library_dockerhub_images
branch
from
c1deabc
to
5d6bf33
Compare
Entepotenz
force-pushed
the
handle_library_dockerhub_images
branch
from
5d6bf33
to
e872e37
Compare
lucacome
approved these changes
Jan 5, 2023
|
I guess we can remove |
lucacome
changed the title
library/ is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed some time to find out that for official docker images you need to add the prefix
library/.I think we could do this automatically detecting that docker is responding with an error and the provided image name does not start with
username/.This will probably save some time for the users of this github action :-)