Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original classes baseline #23

Merged

Conversation

lucamarini22
Copy link
Owner

@lucamarini22 lucamarini22 commented Jun 13, 2023

I created a branch to train a model on the original 11 classes used in MARIDA: A benchmark for Marine Debris detection from Sentinel-2 remote sensing data, and also with the original 15 classes of the dataset. Now it is possible to train with:

  • 15 classes if the arg --aggregate_classes = CategoryAggregation.ALL
  • 11 classes if the arg --aggregate_classes = CategoryAggregation.ELEVEN
  • 5 classes if the arg --aggregate_classes = CategoryAggregation.MULTI
  • 2 classes if the arg --aggregate_classes = CategoryAggregation.BINARY

The classes that correspond to each of the above configuration ca be seen in the assets.py file

@lucamarini22 lucamarini22 added the enhancement New feature or request label Jun 13, 2023
@gomezzz gomezzz removed their assignment Jun 16, 2023
@gomezzz gomezzz self-requested a review June 16, 2023 11:13
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller comments

evaluation.py Show resolved Hide resolved
marineanomalydetection/dataset/aggregator.py Show resolved Hide resolved
marineanomalydetection/parse_args_train.py Show resolved Hide resolved
marineanomalydetection/utils/assets.py Outdated Show resolved Hide resolved
marineanomalydetection/utils/assets.py Show resolved Hide resolved
marineanomalydetection/utils/assets.py Show resolved Hide resolved
@gomezzz
Copy link
Collaborator

gomezzz commented Jun 16, 2023

Also, probably you will want to merge this into main not the other branch, I suspect? 🤔

Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume it's ok but I can't really give feedback because I don't know the intent of the changes. Would advocate for shorter-lived, smaller PRs with clear relationship between

<what_was_the_goal> <-> <what_changed_in_the_code>

(only looked at changes since last review given size ✌️)

lucamarini22 and others added 24 commits August 18, 2023 10:08
…hange intensity only as first augmentation (to avoid changing intensity of padding pixels). Remove the application of augmentations that change intensity of pixels to pseudo labels.
…ing sets setting. Still todo for one training set setting
…works with 0.0 because on the logits of the strongly aug-img I ignore I ignore the padding pixels based on the logits of the weakly aug-img, which has not cutout applied
…Focal loss in the unsup component of the ssl loss. Update descriptions.
…ility of using Cross Entropy in the unsupervised component of the ssl loss
… the loss when using semi-supervised learning
@lucamarini22 lucamarini22 changed the base branch from main to ssl-and-fully-sup-same-batches October 4, 2023 15:21
Copy link
Owner Author

@lucamarini22 lucamarini22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review is ok

Copy link
Owner Author

@lucamarini22 lucamarini22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@lucamarini22 lucamarini22 merged commit 22be673 into ssl-and-fully-sup-same-batches Oct 4, 2023
@lucamarini22 lucamarini22 deleted the original-classes-baseline branch October 4, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants