Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement internal logger #105

Merged
merged 5 commits into from
Apr 18, 2018
Merged

Implement internal logger #105

merged 5 commits into from
Apr 18, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 17, 2018

Link to issue #21 and #45 will resolve #106

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #105 into master will increase coverage by 0.28%.
The diff coverage is 94.82%.

@@            Coverage Diff            @@
##           master    #105      +/-   ##
=========================================
+ Coverage   98.62%   98.9%   +0.28%     
=========================================
  Files          20      22       +2     
  Lines        1451    1548      +97     
=========================================
+ Hits         1431    1531     +100     
+ Misses         20      17       -3
Impacted Files Coverage Δ
Sources/SwiftQueue/JobInfo.swift 98.21% <ø> (+1.72%) ⬆️
Sources/SwiftQueue/JobBuilder.swift 100% <100%> (ø) ⬆️
Tests/SwiftQueueTests/LoggerTests.swift 100% <100%> (ø)
Sources/SwiftQueue/SqOperationQueue.swift 100% <100%> (ø) ⬆️
Tests/SwiftQueueTests/SwiftQueueBuilderTests.swift 100% <100%> (ø) ⬆️
Tests/SwiftQueueTests/SwiftQueueTests.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/SwiftQueueManager.swift 94.59% <75%> (+0.15%) ⬆️
Sources/SwiftQueue/SwiftQueueLogger.swift 77.77% <77.77%> (ø)
Sources/SwiftQueue/SqOperation.swift 98.75% <94.11%> (+4.05%) ⬆️
... and 1 more

@lucas34 lucas34 changed the title [WIP] Kick off event stream for logging purpose [WIP] implement logger Apr 17, 2018
@lucas34 lucas34 changed the title [WIP] implement logger Implement internal logger Apr 18, 2018
@lucas34 lucas34 merged commit 1d8579b into master Apr 18, 2018
@lucas34 lucas34 deleted the eventStream branch April 18, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal logger
1 participant