Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persister by default to avoid having persist(required: true) but no persister #119

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 20, 2018

This is a Breaking Changes

@lucas-bot
Copy link
Collaborator

SwiftLint found issues

Warnings

File Line Reason
SqOperationQueue.swift 17 Line should be 140 characters or less: currently 148 characters
SwiftQueueManager.swift 24 Line should be 140 characters or less: currently 159 characters
SwiftQueueTests.swift 143 Limit vertical whitespace to a single empty line. Currently 2.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@655776b). Click here to learn what that means.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   99.07%           
=========================================
  Files             ?       22           
  Lines             ?     1625           
  Branches          ?        0           
=========================================
  Hits              ?     1610           
  Misses            ?       15           
  Partials          ?        0
Impacted Files Coverage Δ
Tests/SwiftQueueTests/SwiftQueueTests.swift 100% <100%> (ø)
Sources/SwiftQueue/SqOperationQueue.swift 98.48% <100%> (ø)
Sources/SwiftQueue/SwiftQueueManager.swift 97.36% <83.33%> (ø)

@lucas34 lucas34 merged commit 2598882 into master Apr 20, 2018
@lucas34 lucas34 deleted the default-persister branch April 20, 2018 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants