Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JobInfo conform to Codable protocol #120

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Make JobInfo conform to Codable protocol #120

merged 1 commit into from
Apr 20, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 20, 2018

No description provided.

@lucas-bot
Copy link
Collaborator

1 Warning
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Warnings

File Line Reason
Utils.swift 106 Limit vertical whitespace to a single empty line. Currently 2.
Utils.swift 114 Files should have a single trailing newline.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #120 into master will decrease coverage by 4.84%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   98.83%   93.98%   -4.85%     
==========================================
  Files          22       22              
  Lines        1625     1713      +88     
==========================================
+ Hits         1606     1610       +4     
- Misses         19      103      +84
Impacted Files Coverage Δ
Sources/SwiftQueue/Constrains+Network.swift 77.77% <ø> (ø) ⬆️
Sources/SwiftQueue/JobInfo.swift 48.66% <0%> (-49.99%) ⬇️
Sources/SwiftQueue/Utils.swift 78.57% <0%> (-21.43%) ⬇️
Sources/SwiftQueue/Constrains+Deadline.swift 100% <0%> (+22.22%) ⬆️

@lucas34 lucas34 merged commit dae1473 into master Apr 20, 2018
@lucas34 lucas34 deleted the Codable branch April 20, 2018 05:35
@lucas-bot lucas-bot mentioned this pull request Apr 25, 2018
@lucas-bot lucas-bot mentioned this pull request Jun 7, 2018
@lucas-bot lucas-bot mentioned this pull request Aug 29, 2018
This was referenced Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants