Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error not forwarded and not reported with the logger #121

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 20, 2018

No description provided.

@lucas-bot
Copy link
Collaborator

lucas-bot commented Apr 20, 2018

SwiftLint found issues

Warnings

File Line Reason
SqOperationQueue.swift 17 Line should be 140 characters or less: currently 148 characters
Utils.swift 106 Limit vertical whitespace to a single empty line. Currently 2.
Utils.swift 114 Files should have a single trailing newline.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #121 into master will increase coverage by 0.24%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   93.75%   93.99%   +0.24%     
==========================================
  Files          22       22              
  Lines        1713     1715       +2     
==========================================
+ Hits         1606     1612       +6     
+ Misses        107      103       -4
Impacted Files Coverage Δ
Sources/SwiftQueue/SqOperation.swift 100% <ø> (+1.24%) ⬆️
Sources/SwiftQueue/Utils.swift 78.57% <100%> (ø) ⬆️
Tests/SwiftQueueTests/SwiftQueueBuilderTests.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/JobInfo.swift 48.66% <50%> (ø) ⬆️
Sources/SwiftQueue/SqOperationQueue.swift 96% <81.81%> (-2.49%) ⬇️
Sources/SwiftQueue/Constrains+Deadline.swift 100% <0%> (+22.22%) ⬆️

@lucas34 lucas34 merged commit 76d84a6 into master Apr 20, 2018
@lucas34 lucas34 deleted the patch-1 branch April 20, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants