Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error not reported and prevent the job to be serialised #122

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 20, 2018

No description provided.

@lucas-bot
Copy link
Collaborator

lucas-bot commented Apr 20, 2018

SwiftLint found issues

Warnings

File Line Reason
SqOperationQueue.swift 17 Line should be 140 characters or less: currently 148 characters
TestUtils.swift 157 Force unwrapping should be avoided.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #122 into master will decrease coverage by 0.14%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   93.99%   93.85%   -0.15%     
==========================================
  Files          22       22              
  Lines        1715     1724       +9     
==========================================
+ Hits         1612     1618       +6     
- Misses        103      106       +3
Impacted Files Coverage Δ
Tests/SwiftQueueTests/PersisterTests.swift 100% <100%> (ø) ⬆️
Tests/SwiftQueueTests/TestUtils.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/SqOperation.swift 99.34% <75%> (-0.66%) ⬇️
Sources/SwiftQueue/SqOperationQueue.swift 93.9% <77.77%> (-2.1%) ⬇️

@lucas34 lucas34 merged commit e5add16 into master Apr 20, 2018
@lucas34 lucas34 deleted the patch-2 branch April 20, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants