Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require charging constraint #123

Merged
merged 7 commits into from
Apr 23, 2018
Merged

Add require charging constraint #123

merged 7 commits into from
Apr 23, 2018

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Apr 20, 2018

No description provided.

@lucas-bot
Copy link
Collaborator

lucas-bot commented Apr 20, 2018

SwiftLint found issues

Warnings

File Line Reason
Constraints+Charging.swift 19 An object should only remove itself as an observer in deinit.
Constraints+Charging.swift 36 Line should be 140 characters or less: currently 170 characters

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #123 into master will increase coverage by 0.34%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   97.02%   97.36%   +0.34%     
==========================================
  Files          23       24       +1     
  Lines        1679     1707      +28     
==========================================
+ Hits         1629     1662      +33     
+ Misses         50       45       -5
Impacted Files Coverage Δ
Sources/SwiftQueue/Constraints+Charging.swift 100% <100%> (ø)
Sources/SwiftQueue/JobBuilder.swift 100% <100%> (ø) ⬆️
Tests/SwiftQueueTests/ConstraintTests.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/SqOperation.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/JobInfo.swift 88% <100%> (+0.5%) ⬆️
Tests/SwiftQueueTests/SwiftQueueBuilderTests.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/Constrains+Delay.swift 100% <0%> (+9.09%) ⬆️
Sources/SwiftQueue/Constrains+Network.swift 77.77% <0%> (+11.11%) ⬆️

@lucas34 lucas34 merged commit b842cc9 into master Apr 23, 2018
@lucas34 lucas34 deleted the constraint+charging branch April 23, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants