Update sqlmock dependency #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-sqlmock have switched from gopkg.in to Go modules. This repository uses the
new github.com import path, however the go.mod file still uses the old gopkg.in
import path. This confuses `go mod` when importing this package:
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.3: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.3
This commit updates the go.mod import path.
|
Note: the breakage has been caused by #33 |
|
This is unfortunate, especially as sqlmock is only barely used for testing. I'm not up-to-date anymore and have to rely on PRs, so thanks a lot for fixing this! |
|
Thanks for merging this! Could you tag a new minor release so we can use your library without hitting errors? |
|
Thanks for reminding me, here it is: https://github.com/lucasb-eyer/go-colorful/releases/tag/v1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-sqlmock have switched from gopkg.in to Go modules. This repository uses the
new github.com import path, however the go.mod file still uses the old gopkg.in
import path. This confuses
go modwhen importing this package:This commit updates the go.mod import path.
(Please tag a new minor version after merging this)