sync with master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't show regions that aren't in the table * Add more tests, name variables * Fix indent * Update indentation
* Don't close popover if only the time changed * Add unit tests * Fix logic that's causing broken test * Oops, delete .only * Write a failing test for an edge-case * Fix the failing test * Clarify the boolean logic * Change !== to !=
* move empty content check from Tooltip to Popover * remove now unused things * add empty content option to Popover example
- Put dialog example first (_finally_...)
- Document the default behavior correctly (`inline={false}` by default)
…place (#1154) * Clean up navbar styles, rename pages * Add sidebar to hold toggles eventually * Add toggle for ghost cells * Add toggle for 'Show focus cell', with slight refactors * Enable context menu * Enable full-table selection * Enable multiple selections * Enable row and column selection * Enable row and column resizing * Enable row and column reordering * Show column menus * Enable column name editing * Show inline, better styles * Change row and column counts * Make sidebar scrollable * Show row and column headers loading * Show row headers * Enable most features by default * Increase default row count * Show cells loading * Enable cell selection * Enable cell editing * Enable zebra striping * Custom regions * Better styles * Focus style control * Sync focus style on componentDidMount too
- Upgrade to Chai 4.0 to get includeDeepMembers assertion - Remove tests that were mostly tautological and relied on old lenient APIs
…component (#1140) * Write AbstractHeader and AbstractHeaderCell * Refactor RowHeader to extend from AbstractHeader * Move IColumnHeaderRenderer into columnHeader.tsx * Extend IHeaderProps in ColumnHeader * Refactor ColumnHeader to extend from AbstractHeader * Refactor {Row,Column}HeaderCell to extend from AbstractHeaderCell * Fix lint * Respond to self-CR feedback * Various cleanups - Reorder protected methods alphabetically - Delete unneeded onResizeGuide from IColumnHeaderProps - Rename handleDoubleClick to handleResizeHandleDoubleClick * Write abstractHeader2.tsx using composition this time * Use AbstractHeader2 in ColumnHeader2 and RowHeader2 * Make AbstractHeaderCell a component, not a superclass * Delete old inheritance-approach files * Fix file path references * Fix bug: pass classname to AbstractHeaderCell * Rename *2.tsx to *.tsx * Respond to self CR * Respond to Adi CR feedback * Rename to Header and HeaderCell * Spread props * Spread props in header cell components * Oops, add 'from'
* Rename perf.html, make it the home page for the table preview * Change page titles * Fix lint
…false (#1171) * Have focused cell follow selection if allowMultipleSelection=false * Add test * Fix broken test
* Move focus cell to (0,0) on FULL_TABLE selection * Add test
* Row => Rows * Fix name renderFocuStyleSelectMenu => renderFocusStyleSelectMenu * Fix console errors * Reorder stuff in the sidebar * Rename multi-selection option * Respond to Gilad CR feedback
* Fix bugs in Utils.deepCompareKeys * Drastically trim re-renders by deep-comparing selectedRegions in shouldComponentUpdate * Deeply compare props in controlled mode * Respond to CR feedback
* Add onButtonClick prop, add test * Respond to CR feedback
…klist (#1181) * Refactor shallowCompareKeys to accept black/white list * Switch to blacklist for table.tsx * Fix lint * Respond to CR feedback
* Only use table cells for resizeByTallest, not header cells * Fix table test
* Fix hover transition flicker on cards
- new labs package for components in development - new InputList and Select components for choosing an item from a list
* Fix lint error in Table#columnHeaderCellRenderer * Fix lint (such irony)
* ignore code coverage in linters * handle unknown interface tags
…1206) * Custom shouldComponnentUpdate in EditableCell * Delete HeaderCell's shallowlyComparablePropKeysList prop * Add custom shouldComponentUpdate to Header (plus PureRender for RowHeader)
* Show grab cursor on interaction bar * Fix header menu styles when selection disabled * Fix grabbing style when :active
* Fix lint error in EditableCell * Delete whitespace per CR feedback
* Write shouldHeaderComponentUpdate helper in header.tsx, use in higher-level components * Fix lint * Mention Github issue * Change comment to rescind promises
…cks (#1210) * Add optional rowIndex and columnIndex props to Cell * Include rowIndex and columnIndex as params in EditableCell callbacks * Add optional index prop to HeaderCell * Provide index from columnHeader.tsx and rowHeader.tsx * Provide index to ColumnHeaderCell#renderName callback * Refactor index.tsx code to take advantage of index param * Use fat arrow for renderCell in index.tsx * Pass indices to body EditableCell in index.tsx, refactor callback * Fix lint in rowHeader.tsx * Add tests * Address CR feedback
* Consider enableFocus in componentWillReceiveProps * Consider selectionModes in componentWillReceiveProps * Sync scroll position when number of rows or columns decreases * Respond to CR feedback * Update viewport too, start writing tests * Decomp tests, write more of them * Clean up tests * Fix lint * Respond to CR feedback * Add test for setting enableFocus to false * Add tests for selectionModes changing * Fix lint * Respond to CR feedback
…ABLE selections too (#1217) * Have column headers and row headers respond to FULL_TABLE selections too * Create new 'describe' group for full-table selection tests * Add new test placeholders * Refactor test code * Write new test, rework test code a bit * Fix lint
* Batch child rendering Add or remove a limited number of children at a time to reduce to DOM reconcilation time. This removes jank from scrolling, but introduces a "scanline" render style for table cells. This is preferable to slow, janky framerates. * Use blacklist to reset batcher * lint * Fix tests by reset batcher on state change * PR Comments * Fix isotest * fix merge issue * Also batch UPDATES. Add unit test to confirm. * fix isotest * Fix resize updates. Update test to confirm * lint * PR Comments
…nu prop (#1218) * Add renderMenu prop to HeaderCell * Use renderMenu in columnHeaderCell * Throw deprecation warnings from each header cell component * Use renderMenu in index.tsx to get rid of deprecation warnings * Move to multiline import * Write unit test
…eyValues (#1222) * Add new Table utils: getShallowUnequalKeyValues and getDeepUnequalKeyValues * Refactor table util fns tests * Reorder functions in table tests * Write tests for getShallowlyUnequalKeyValues * Write tests for getDeepUnequalKeyValues * Fix lint
* Don't use anon fns for ColumnHeaderCell popover callbacks * Little cleanups in index.tsx * Move away from .bind(this) in index.tsx
* Prepare Release 1.20.0 * Fix version numbers in site-docs/package.json
* Add cell-content menu, refactor * Change cell content based on selection * Add option for long text * Delete 'Fill with random text' option * Use Utils.times instead of for loop * CR feedback * Respond to CR feedback * More CR feedback
* Add locator to table component for use in functions * Use locator directly * remove locator from state * Fix test use of locator
Add support for a portal classname from the react context
* initial TagInput implementation * docs + polish * tests! sufficient coverage 👍 * move code to subdirectory, use "fake" names * add Tag active prop and .pt-active style support * left/right arrows to navigate through tags list and remove _any_ (not just last) * fix lint * refactor keyboard logic and introduce NONE constant * set explicit width to break long words * notes, remove commented code * 🌳 remove logs * rename dir to tag-input * add docs about keyboard interactions
…1239) * Have EditableCell fully control value in child EditableText * Respond to CR feedback * Add test
* Add cell-content menu, refactor * Change cell content based on selection * Add option for long text * Delete 'Fill with random text' option * Use Utils.times instead of for loop * CR feedback * Respond to CR feedback * More CR feedback * Add basic truncation * Add default value for zebra striping to fix warning * Add select menu for truncated popover mode * Move to switch statement * Fix lint * Clearer [title] tooltip message * Show disabled child elements in sidebar, use Classes everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.