Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sbyte, ushort, uint, ulong and nuint #18

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

koryphaee
Copy link

I basically just copy-pasted the code for the existing types including tests. These commits look very similar to those adding short, byte etc. (8247470).

@koryphaee
Copy link
Author

I had to introduct a new flag IsSigned to prevent the negation operator from being generated for unsigned types causing compiler errors.

@koryphaee
Copy link
Author

I had to add some casts to the math operators because some types like short and byte do not yield their own type for math operators. short + short = int etc.

@lucasteles
Copy link
Owner

lucasteles commented Dec 12, 2024

@koryphaee Looks good,

Note

I want to rethink those template styles to reduce the "copy/paste" for new types in the future

I had to introduct a new flag IsSigned to prevent the negation operator from being generated for unsigned types causing compiler errors.

The only request I have is that it would be better to merge the definitions of those bools IsNumeric and IsSigned into an Enum type:

enum NumericKind { 
  None, 
  Signed, 
  Unsigned 
}

@koryphaee
Copy link
Author

Will do 👍

@koryphaee
Copy link
Author

pushed the enum change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants