Fix mounts for non mmcblk devices #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this PR. I would prefer to just have a variable that would overwrite the existing disk name instead. It feels cleaner, sure a little less automated but at least keeps it far more flexible and no need to have a lot of logic to try and determine the disk name automatically. I find Makefile syntax to be quite ugly and unreadable, try to use it as an entry point and keep it simple. What do you think? |
|
That is what this does already....?
…On Mon, Jan 20, 2020, 4:25 AM Lucas Teligioridis ***@***.***> wrote:
Sorry for the delay on this PR.
I would prefer to just have a variable that would overwrite the existing
disk name instead.
It feels cleaner, sure a little less automated but at least keeps it far
more flexible and no need to have a lot of logic to try and determine the
disk name automatically.
What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=AAAJEL7GTZWYQGAM36ULEZTQ6VUYLA5CNFSM4KD2ZV7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJL54KY#issuecomment-576183851>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJELZ4YHBPTZJMBFW5S4DQ6VUYLANCNFSM4KD2ZV7A>
.
|
|
Well it would have 2 variables that would look like instead: |
|
Going to close this PR if no further discussion is made on the above comment. Just want to politely bump. |
|
Closing to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issue #1