Add GitLab as a source for repositories

[zillemarco]

This PR adds GitLab as a source for repositories 🥳

[zillemarco]

@ltickett @souldzin here we go 🙂

@lucavallin feel free to have a look and let's start from here 💪 🙂

[ltickett]

@zillemarco we may just want to review the list of projects we included (we picked a bit random/haphazzardly)

I think GitLab is the only one which meets the 1,000 stars requirement, though me and Paul had a look and it seems GitHub is used very differently to GitLab.

On GitHub repos tend to have more stars than forks. On GitLab it's the other way around?

[zillemarco]

That's a very good point 🤔 Are you proposing to update the "filter" to count the number of forks instead of stars for repositories coming from GitLab?

I'll update the projects to only keep GitLab's project for now anyway 🙂

[souldzin]

That's a very good point 🤔 Are you proposing to update the "filter" to count the number of forks instead of stars for repositories coming from GitLab?

I'll update the projects to only keep GitLab's project for now anyway 🙂

suggestion: GitLab has some satellite projects that might be nice to include. I'm thinking of gitaly, gitlab-ui, and gitlab-web-ide.

Your call @zillemarco 😄

[zillemarco]

That's a very good point 🤔 Are you proposing to update the "filter" to count the number of forks instead of stars for repositories coming from GitLab?
I'll update the projects to only keep GitLab's project for now anyway 🙂

suggestion: GitLab has some satellite projects that might be nice to include. I'm thinking of gitaly, gitlab-ui, and gitlab-web-ide.

Only issue with those projects is that they would get filtered out by the number of stars 😅

[ltickett]

Are you proposing to update the "filter" to count the number of forks instead of stars for repositories coming from GitLab?

@zillemarco - no. Just that i'm not sure if we need to apply exactly the same rules to which projects we can/can't include?

We may need a bit of direction from @lucavallin - or may be given a little "artistic license" :)

[zillemarco]

or may be given a little "artistic license" :)

Sounds good 😄

[lucavallin]

@ltickett @zillemarco @souldzin Thanks for your contributions, it's looking great so far. I added a comment or two ;)
Furthermore, I am not familiar with GitLab, but it's reasonable to have a different filter for it to account for different dynamics. Come up with something sensible, "artistic license" granted.

@cloudhoy Might also have an opinion on the generate.ts script because of recent contributions.

[cloudhoy]

@lucavallin Thanks for the ping! 😄

Hi everyone! Just wanted to add my two cents to this discussion.

I'm wondering if lowering the star requirement for GitLab may be a little "unfair" to developers on GitHub who want to add their repositories to firstissue.dev but are unable to meet the 1,000 star requirement.

Perhaps we should just lower the star requirements across the board instead? 🤔

[nickveenhof]

@lucavallin Thanks for the ping! 😄

Hi everyone! Just wanted to add my two cents to this discussion.

I'm wondering if lowering the star requirement for GitLab may be a little "unfair" to developers on GitHub who want to add their repositories to firstissue.dev but are unable to meet the 1,000 star requirement.

Perhaps we should just lower the star requirements across the board instead? 🤔

I'm not opposed to even lowering or removing the requirement completely. The current process is to manually add the repository to firstissue.json anyway, so I don't see why any of those filters would even need to be in the list. Perhaps a great improvement wouldbe some documentation that you need to have at least 5 issues with any of those labels present at all times to qualify to get in the list? That seems more fair?

Also, I believe this is a separate discussion, should we move this to a new issue?

[lucavallin]

I disagree with removing the requirements: they are definitely arbitrary and can be discussed and changed, but they are to ensure some level of quality of the repos that make it to the list. The idea of FirstIssue is not only to find a project to contribute to, but to find one that is relevant, somewhat "famous", that you'd be eager to contribute to and proud of doing so, and that you'd add on your LinkedIn / resume. There are other websites like FirstIssue that are full of (mostly) irrelevant 100-stars "twitter-ios-clone" projects and we want to avoid that ;) That obviously cuts out super-awesome repos with 890 stars, but we need to draw the line somewhere.

However, if GitLab has ~1/3 of the users of GitHub, then I think it's fair to have different requirements for it, since 350 stars on GitLab = 1050 stars on GitHub (well, naïve math, but you get the point...). I am not sure what those requirements should be though 🙂.

[zillemarco]

However, if GitLab has ~1/3 of the users of GitHub, then I think it's fair to have different requirements for it, since 350 stars on GitLab = 1050 stars on GitHub (well, naïve math, but you get the point...). I am not sure what those requirements should be though 🙂.

I used 300 stars as a "stopping point" for projects coming from GitLab (more round number than 350, plus it let a couple more projects in 😅)

[zillemarco]

@lucavallin sorry it took me this long but I now have pushed up the changes and rebased with your latest changes (quite a refactor 😅)

I think this is good for you to have another look now 👍 🙂

[lucavallin]

Hey @zillemarco! Looks good, thanks for the changes.

1. There is a conflict in config.json, please make sure new repos are synced.
2. Do we need any kind of auth for GitLab?
3. Let me know if/when you're ready to merge this

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @lucavallin on Vercel.

@lucavallin first needs to authorize it.

[zillemarco]

@lucavallin I just resolved the conflict, so we're good to merge if that's ok with you as well 🙂

And there's no need for authorization for GitLab, we're using only public APIs 👍

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
first-issue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2023 8:40pm

[lucavallin]

Please double-check deployment on Vercel before merging.
Awesome contribution - thank you for it!

[zillemarco]

@lucavallin the vercel message is for you, right? 🤔 I can't access the deployment 🤔

[lucavallin]

@zillemarco So it seems... but it is successful!

[zillemarco]

🥳 thank you @lucavallin 😄