Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out sliders/settings/cog/gear icons #1300

Closed
wants to merge 12 commits into from

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented May 21, 2023

Following on from #231 and #987 (comment)

Also related to #1225.

@vercel
Copy link

vercel bot commented May 21, 2023

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented May 21, 2023

Added or changed icons

icons/sliders-big-vertical.svgicons/sliders-horizontal.svgicons/sliders-vertical.svgicons/cogwheel.svgicons/gear.svgicons/sliders-big-horizontal.svg

Preview cohesion icons/square-user.svgicons/square-play.svgicons/square-sigma.svgicons/messages-square.svgicons/square-scissors.svgicons/square-stack.svg
icons/sliders-big-vertical.svgicons/sliders-horizontal.svgicons/sliders-vertical.svgicons/cogwheel.svgicons/gear.svgicons/sliders-big-horizontal.svg
icons/shield-minus.svgicons/scaling.svgicons/italic.svgicons/thermometer-snowflake.svgicons/dumbbell.svgicons/music-4.svg
Preview stroke widths icons/sliders-big-vertical.svgicons/sliders-horizontal.svgicons/sliders-vertical.svgicons/cogwheel.svgicons/gear.svgicons/sliders-big-horizontal.svg
icons/sliders-big-vertical.svgicons/sliders-horizontal.svgicons/sliders-vertical.svgicons/cogwheel.svgicons/gear.svgicons/sliders-big-horizontal.svg
icons/sliders-big-vertical.svgicons/sliders-horizontal.svgicons/sliders-vertical.svgicons/cogwheel.svgicons/gear.svgicons/sliders-big-horizontal.svg
DPI Preview (24px) icons/sliders-big-vertical.svg icons/sliders-horizontal.svg icons/sliders-vertical.svg icons/cogwheel.svg icons/gear.svg icons/sliders-big-horizontal.svg
Icon X-rays icons/sliders-big-vertical.svg icons/sliders-horizontal.svg icons/sliders-vertical.svg icons/cogwheel.svg icons/gear.svg icons/sliders-big-horizontal.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SlidersBigVerticalIcon = createLucideIcon('SlidersBigVertical', [
  ["circle",{"cx":"7","cy":"7","r":"3"}],
  ["path",{"d":"M7 10v10"}],
  ["circle",{"cx":"17","cy":"17","r":"3"}],
  ["path",{"d":"M17 4v10"}]
])

const SlidersHorizontalIcon = createLucideIcon('SlidersHorizontal', [
  ["path",{"d":"M10 4H3"}],
  ["path",{"d":"M14 2v4"}],
  ["path",{"d":"M21 4h-7"}],
  ["path",{"d":"M8 12H3"}],
  ["path",{"d":"M8 10v4"}],
  ["path",{"d":"M21 12h-9"}],
  ["path",{"d":"M12 20H3"}],
  ["path",{"d":"M16 18v4"}],
  ["path",{"d":"M21 20h-5"}]
])

const SlidersVerticalIcon = createLucideIcon('SlidersVertical', [
  ["path",{"d":"M4 10V3"}],
  ["path",{"d":"M2 14h4"}],
  ["path",{"d":"M4 21v-7"}],
  ["path",{"d":"M12 8V3"}],
  ["path",{"d":"M10 8h4"}],
  ["path",{"d":"M12 21v-9"}],
  ["path",{"d":"M20 12V3"}],
  ["path",{"d":"M18 16h4"}],
  ["path",{"d":"M20 21v-5"}]
])

const CogwheelIcon = createLucideIcon('Cogwheel', [
  ["path",{"d":"M12.22 2h-.44a2 2 0 0 0-2 2v.18a2 2 0 0 1-1 1.73l-.43.25a2 2 0 0 1-2 0l-.15-.08a2 2 0 0 0-2.73.73l-.22.38a2 2 0 0 0 .73 2.73l.15.1a2 2 0 0 1 1 1.72v.51a2 2 0 0 1-1 1.74l-.15.09a2 2 0 0 0-.73 2.73l.22.38a2 2 0 0 0 2.73.73l.15-.08a2 2 0 0 1 2 0l.43.25a2 2 0 0 1 1 1.73V20a2 2 0 0 0 2 2h.44a2 2 0 0 0 2-2v-.18a2 2 0 0 1 1-1.73l.43-.25a2 2 0 0 1 2 0l.15.08a2 2 0 0 0 2.73-.73l.22-.39a2 2 0 0 0-.73-2.73l-.15-.08a2 2 0 0 1-1-1.74v-.5a2 2 0 0 1 1-1.74l.15-.09a2 2 0 0 0 .73-2.73l-.22-.38a2 2 0 0 0-2.73-.73l-.15.08a2 2 0 0 1-2 0l-.43-.25a2 2 0 0 1-1-1.73V4a2 2 0 0 0-2-2z"}],
  ["circle",{"cx":"12","cy":"12","r":"3"}]
])

const GearIcon = createLucideIcon('Gear', [
  ["circle",{"cx":"12","cy":"12","r":"8"}],
  ["circle",{"cx":"12","cy":"12","r":"2"}],
  ["path",{"d":"M12 2v2"}],
  ["path",{"d":"M12 22v-2"}],
  ["path",{"d":"m17 20.66-1-1.73"}],
  ["path",{"d":"M11 10.27 7 3.34"}],
  ["path",{"d":"m20.66 17-1.73-1"}],
  ["path",{"d":"m3.34 7 1.73 1"}],
  ["path",{"d":"M14 12h8"}],
  ["path",{"d":"M2 12h2"}],
  ["path",{"d":"m20.66 7-1.73 1"}],
  ["path",{"d":"m3.34 17 1.73-1"}],
  ["path",{"d":"m17 3.34-1 1.73"}],
  ["path",{"d":"m11 13.73-4 6.93"}]
])

const SlidersBigHorizontalIcon = createLucideIcon('SlidersBigHorizontal', [
  ["path",{"d":"M20 7H10"}],
  ["path",{"d":"M14 17H5"}],
  ["circle",{"cx":"17","cy":"17","r":"3"}],
  ["circle",{"cx":"7","cy":"7","r":"3"}]
])

@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2023 11:34pm

@danielbayley
Copy link
Member Author

My two cents:

  • settings should be gear
  • sliders should be sliders-vertical
  • settings-2 should be something like sliders-large-vertical
    (but I still prefer your design, it makes it more obvious that they're sliders, not circles on sticks)
  • cog should either remain cog or if we want to be semantically correct, it could become cogwheel

@karsa-mistmere This should be good to go now… @ericfennis

@danielbayley danielbayley changed the title Fix/optimise/add sliders/settings/cog/gear icons Sort out sliders/settings/cog/gear icons Jun 6, 2023
@karsa-mistmere
Copy link
Member

karsa-mistmere commented Jun 7, 2023

I still prefer your original redesign to these. 😅
image

Really sells the sliders use case as opposed to "lollipops-left-right".

@danielbayley
Copy link
Member Author

danielbayley commented Jun 7, 2023

I still prefer your original redesign for these. 😅

@karsa-mistmere Ha well I now prefer the simplicity of the original 😅 …and have since noticed it all over the place!

Maybe we should put it to a vote (need that bot again…) cc: @ericfennis @jguddas

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 8, 2023
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants