-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock icons #1346
Lock icons #1346
Conversation
Co-authored-by: Jakob Guddas <github@jguddas.de>
Co-authored-by: Jakob Guddas <github@jguddas.de>
@cd16b Nice! I had something very similar drafted… Just with a slightly more keyhole shape: Also, maybe better to name them [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice like these!
What is the use case for this icon that is currently not covered by |
Not really in favour of adding these as separate icons. Either let's change the OG lock icons or drop these, I think they're way too similar to be a separate set. |
Ok you decide, I proposed it as many icon sets have similar ones |
@ericfennis: I've reviewed this again, upon further reflection I'm okay with adding these as alts just as long as the base lock shape is the same in both icons (i.e. the core icons are also updated), although I think I'd rather stick to either |
@karsa-mistmere awesome. I think we should go for simple and go for the |
I think it works OK, definitely sells the illusion of a keyhole, and even scaled up it looks pretty decent: |
@karsa-mistmere True, I'm okay with both ways. I think the dot is a more simplistic design that fits with the lucide style. But the keyhole is more recognizable and more useful when scaled up. |
@cd16b Can you update the names to |
Co-authored-by: Jakob Guddas <github@jguddas.de>
Co-authored-by: Jakob Guddas <github@jguddas.de>
No description provided.