Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock icons #1346

Merged
merged 19 commits into from
Oct 2, 2023
Merged

Lock icons #1346

merged 19 commits into from
Oct 2, 2023

Conversation

cd16b
Copy link
Contributor

@cd16b cd16b commented Jun 6, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Added or changed icons

icons/lock-keyhole.svg icons/unlock-keyhole.svg

Preview cohesion icons/gantt-chart-square.svg icons/kanban-square-dashed.svg
icons/lock-keyhole.svg icons/unlock-keyhole.svg
icons/cloud-snow.svg icons/refresh-cw.svg
Preview stroke widths icons/lock-keyhole.svg icons/unlock-keyhole.svg
icons/lock-keyhole.svg icons/unlock-keyhole.svg
icons/lock-keyhole.svg icons/unlock-keyhole.svg
DPI Preview (24px) icons/lock-keyhole.svg icons/unlock-keyhole.svg
Icon X-rays icons/lock-keyhole.svg icons/unlock-keyhole.svg

@danielbayley
Copy link
Member

danielbayley commented Jun 6, 2023

@cd16b Nice! I had something very similar drafted… Just with a slightly more keyhole shape:

preview



Also, maybe better to name them [un]lock-dot (or [un]lock-keyhole, if you prefer these…)

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice like these!

@jguddas
Copy link
Member

jguddas commented Jun 11, 2023

What is the use case for this icon that is currently not covered by lock?

@karsa-mistmere
Copy link
Member

Not really in favour of adding these as separate icons. Either let's change the OG lock icons or drop these, I think they're way too similar to be a separate set.

@cd16b
Copy link
Contributor Author

cd16b commented Jun 13, 2023

Either let's change the OG lock icons or drop these

Ok you decide, I proposed it as many icon sets have similar ones

@karsa-mistmere
Copy link
Member

@ericfennis: I've reviewed this again, upon further reflection I'm okay with adding these as alts just as long as the base lock shape is the same in both icons (i.e. the core icons are also updated), although I think I'd rather stick to either lock-dot or lock-keyhole not both:
image

@ericfennis
Copy link
Member

@karsa-mistmere awesome. I think we should go for simple and go for the lock-dot. Since on 100% scale you probably won't see the keyhole that well.

icons/lock-dot.svg Outdated Show resolved Hide resolved
icons/unlock-dot.svg Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member

@karsa-mistmere awesome. I think we should go for simple and go for the lock-dot. Since on 100% scale you probably won't see the keyhole that well.

image

I think it works OK, definitely sells the illusion of a keyhole, and even scaled up it looks pretty decent:
image

@ericfennis
Copy link
Member

@karsa-mistmere True, I'm okay with both ways. I think the dot is a more simplistic design that fits with the lucide style. But the keyhole is more recognizable and more useful when scaled up.

@github-actions github-actions bot added the 🎨 icon About new icons label Jul 2, 2023
@ericfennis
Copy link
Member

@cd16b Can you update the names to lock-keyhole? probably a more logical name.
And I'm still open to changing back to the keyhole designs instead of the dot.

@ericfennis ericfennis merged commit 614ef1a into lucide-icons:main Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants