Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flora icons #1398

Merged
merged 25 commits into from
Jan 5, 2024
Merged

Add flora icons #1398

merged 25 commits into from
Jan 5, 2024

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 25, 2023

trees-forest matches tent-tree in #1409 (comment).

flower-rose-single alts…

preview

Also been playing around with some animation for something else…

rose


cactus alts…

preview

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 25, 2023

Added or changed icons

icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg

Preview cohesion icons/square-asterisk.svg icons/square-dashed-bottom-code.svg icons/arrow-down-square.svg icons/kanban-square-dashed.svg icons/message-square-plus.svg icons/arrow-up-left-square.svg icons/function-square.svg icons/message-square-dashed.svg
icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg
icons/syringe.svg icons/file-text.svg icons/building-2.svg icons/beer.svg icons/sun-snow.svg icons/joystick.svg icons/key.svg icons/angry.svg
Preview stroke widths icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg
icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg
icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg
Icon X-rays icons/cactus.svg icons/flower-pot.svg icons/flower-rose-single.svg icons/flower-rose.svg icons/flower-stem.svg icons/flower-tulip.svg icons/pond.svg icons/trees-forest.svg

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbayley Nice work, the icons are nice.
But I think multiple variants for some are a bit too much.
So I think one cactus and one tree-forest is enough.

I doubt the design for the pond, not sure if the clear what the design tries to tell on 100%.

@danielbayley
Copy link
Member Author

I think one cactus

@ericfennis Between the commited variants and the alts posted above, which do you think…? cc: @karsa-mistmere @jguddas

@ericfennis
Copy link
Member

@danielbayley So for the icons icon, I vote for the third one in the examples in your description.

@ericfennis
Copy link
Member

Oh I thought more one of those ones.
image

I think those ones are a bit more recognizable for a simple cactus.
Like this:
image

Let me know what you think.

@danielbayley
Copy link
Member Author

@ericfennis See latest changes…

@jguddas
Copy link
Member

jguddas commented Aug 12, 2023

Those two lily pads look a bit out of place, what about something like this?

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 16, 2023
@ericfennis ericfennis changed the base branch from main to lab January 5, 2024 16:26
@ericfennis ericfennis merged commit 19cf36b into lucide-icons:lab Jan 5, 2024
@ericfennis
Copy link
Member

This PR is merged to the lab branch. This PR does not match our PR template, which requires valid use cases. To move on we merged this PR to the lab branch, which will be moved to a separate repo in the future.

@jguddas jguddas mentioned this pull request Mar 10, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants