feat: optimized accessibility icons #1574

jguddas · 2023-09-23T12:44:43Z

No description provided.

github-actions · 2023-09-23T12:45:00Z

Added or changed icons

Preview cohesion

Preview stroke widths

DPI Preview (24px)

Icon X-rays

jguddas · 2023-09-23T12:53:21Z

@karsa-mistmere @ericfennis is a change like we see in the thumb of the hand icon acceptable?

ericfennis · 2023-09-24T17:50:07Z

@jguddas No, now it creates a blurry line. See 100% view.

karsa-mistmere · 2023-10-03T07:55:34Z

icons/accessibility.svg

+  <path d="m5 8 3-3 5.5 3-2.4 3.5" />
+  <path d="M4.2 14.5a5 5 0 0 0 6.92 6" />
+  <path d="M13.8 17.5a5 5 0 0 0-6.92-6" />


These paths don't match up correctly:

karsa-mistmere · 2023-10-13T13:47:17Z

icons/ear-off.svg

+  <path d="m2 2 20 20" />
+  <path d="M6 18.5a3.5 3.5 0 1 0 7 0c0-1.57.92-2.52 2-3.5" />
+  <path d="M6 8.5a6.58 6.58 0 0 1 .36-2.14" />
+  <path d="M8.8 3.2A6.5 6.5 0 0 1 19 8.5a7.16 7.16 0 0 1-1.09 3.76" />


This path is pretty over-optimized and off grid, the bottom part isn't even an arc, so I think we should stick with a curve:

Suggested change

<path d="M8.8 3.2A6.5 6.5 0 0 1 19 8.5a7.16 7.16 0 0 1-1.09 3.76" />

<path d="M8.81 3.15A6.5 6.5 0 0 1 17.85 12.19c0 1.63-.44 2.81-1.09 3.76" />

karsa-mistmere · 2023-10-13T13:48:44Z

icons/life-buoy.svg

+  <path d="m4.9 4.9 4.3 4.3" />
+  <path d="m14.8 9.2 4.3-4.3" />
+  <path d="m14.8 14.8 4.3 4.3" />
+  <path d="m9.2 14.8-4.3 4.3" />


This one's also very over-optimised:

I think the original was just fine:

Suggested change

<path d="m4.9 4.9 4.3 4.3" />

<path d="m14.8 9.2 4.3-4.3" />

<path d="m14.8 14.8 4.3 4.3" />

<path d="m9.2 14.8-4.3 4.3" />

<path d="m4.93 4.93 4.24 4.24" />

<path d="m14.83 9.17 4.24-4.24" />

<path d="m14.83 14.83 4.24 4.24" />

<path d="m9.17 14.83-4.24 4.24" />

karsa-mistmere · 2023-10-13T13:51:56Z

icons/speech.svg

@@ -9,7 +9,7 @@
  stroke-linecap="round"
  stroke-linejoin="round"
 >
-  <path d="M8.8 20v-4.1l1.9.2a2.3 2.3 0 0 0 2.164-2.1V8.3A5.37 5.37 0 0 0 2 8.25c0 2.8.656 3.054 1 4.55a5.77 5.77 0 0 1 .029 2.758L2 20" />
+  <path d="M8.8 20v-4.1l1.9.2a2.3 2.3 0 0 0 2.164-2.1l.036-5.7A5.37 5.37 0 0 0 2 8.25c0 2.8.656 3.054 1 4.55a5.77 5.77 0 0 1 .029 2.758L2 20" />


Not sure what happened to this one but both versions are totally off grid. This is more in line with the original design and is even smaller:

Suggested change

<path d="M8.8 20v-4.1l1.9.2a2.3 2.3 0 0 0 2.164-2.1l.036-5.7A5.37 5.37 0 0 0 2 8.25c0 2.8.656 3.054 1 4.55a5.77 5.77 0 0 1 .029 2.758L2 20" />

<path d="M9 20v-4.44c1 .37 2.15.7 3 .07a2.5 2.5 0 0 0 1-2V8.5a5.5 5.5 0 1 0-11 0c0 2.8.66 2.8 1 4.3.23.9.24 1.85.03 2.76L2 20" />

karsa-mistmere · 2023-10-13T13:53:52Z

icons/sun-dim.svg

+  <path d="M17.7 6.3h.01" />
+  <path d="M17.7 17.7h.01" />
+  <path d="M6.3 17.7h.01" />
+  <path d="M6.3 6.3h.01" />


I think this is also sorely over-optimised.

Suggested change

<path d="M17.7 6.3h.01" />

<path d="M17.7 17.7h.01" />

<path d="M6.3 17.7h.01" />

<path d="M6.3 6.3h.01" />

<path d="M17.66 6.34h.01" />

<path d="M17.66 17.66h.01" />

<path d="M6.34 17.66h.01" />

<path d="M6.34 6.44h.01" />

karsa-mistmere · 2023-10-13T13:54:48Z

icons/sun-medium.svg

+  <path d="m18.4 5.6-.7.7" />
+  <path d="m6.3 17.7-.7.7" />
+  <path d="m5.6 5.6.7.7" />
+  <path d="m17.7 17.7.7.7" />


Suggested change

<path d="m18.4 5.6-.7.7" />

<path d="m6.3 17.7-.7.7" />

<path d="m5.6 5.6.7.7" />

<path d="m17.7 17.7.7.7" />

<path d="m18.36 5.64-.7.7"/>

<path d="m6.34 17.66-.7.7"/>

<path d="m5.64 5.64.7.7"/>

<path d="m17.66 17.66.7.7"/>

karsa-mistmere · 2023-10-13T13:55:35Z

icons/sun.svg

+  <path d="m4.9 4.9 1.4 1.4" />
+  <path d="m17.7 17.7 1.4 1.4" />


Over-optimised.

Suggested change

<path d="m4.9 4.9 1.4 1.4" />

<path d="m17.7 17.7 1.4 1.4" />

<path d="m4.93 4.93 1.41 1.41" />

<path d="m17.66 17.66 1.41 1.41" />

karsa-mistmere · 2023-10-13T13:55:35Z

icons/sun.svg

+  <path d="m6.3 17.7-1.4 1.4" />
+  <path d="m19.1 4.9-1.4 1.4" />


Over-optimised.

Suggested change

<path d="m6.3 17.7-1.4 1.4" />

<path d="m19.1 4.9-1.4 1.4" />

<path d="m6.34 17.66-1.41 1.41" />

<path d="m19.07 4.93-1.41 1.41" />

karsa-mistmere · 2023-10-13T13:56:40Z

icons/zoom-in.svg

-  <line x1="11" x2="11" y1="8" y2="14" />
-  <line x1="8" x2="14" y1="11" y2="11" />
+  <path d="M11 8v6" />
+  <path d="m21 21-4.3-4.3" />


Suggested change

<path d="m21 21-4.3-4.3" />

<path d="m21 21-4.34-4.34" />

karsa-mistmere · 2023-10-13T13:56:50Z

icons/zoom-out.svg

@@ -10,6 +10,6 @@
  stroke-linejoin="round"
 >
  <circle cx="11" cy="11" r="8" />
-  <line x1="21" x2="16.65" y1="21" y2="16.65" />
-  <line x1="8" x2="14" y1="11" y2="11" />
+  <path d="m21 21-4.3-4.3" />


Suggested change

<path d="m21 21-4.3-4.3" />

<path d="m21 21-4.34-4.34" />

search should also be updated accordingly.

See Karsa's review

github-actions · 2023-11-13T02:02:58Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

karsa-mistmere · 2023-11-13T09:39:18Z

@jguddas Why did you close this one? 🤔

jguddas · 2023-11-13T11:49:54Z

Gotta have to split it up and make it one PR per icon.

feat: optimized accessibility icons

3b9a13c

github-actions bot added the 🎨 icon About new icons label Sep 23, 2023

feat: optimized accessibility icons

740fb6c

vercel bot deployed to Preview September 23, 2023 12:59 View deployment

jguddas added 3 commits September 23, 2023 15:15

Update baby.svg

8c25e2f

Update baby.svg

6c50c9f

Update baby.svg

ee19301

vercel bot deployed to Preview September 23, 2023 14:51 View deployment

jguddas added 2 commits October 13, 2023 15:11

Merge branch 'main' into feat/optimized-accessibility-icons

9267a76

Update hand.svg

aa3cecb

jguddas requested review from ericfennis and karsa-mistmere October 13, 2023 13:15

vercel bot deployed to Preview October 13, 2023 13:26 View deployment

ericfennis previously approved these changes Oct 13, 2023

View reviewed changes

karsa-mistmere requested changes Oct 13, 2023

View reviewed changes

github-actions bot added the Stale label Nov 13, 2023

jguddas closed this Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: optimized accessibility icons #1574

feat: optimized accessibility icons #1574

jguddas commented Sep 23, 2023

github-actions bot commented Sep 23, 2023 •

edited

Loading

jguddas commented Sep 23, 2023

ericfennis commented Sep 24, 2023

karsa-mistmere Oct 3, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

karsa-mistmere Oct 13, 2023

github-actions bot commented Nov 13, 2023

karsa-mistmere commented Nov 13, 2023

jguddas commented Nov 13, 2023

	<path d="M8.8 3.2A6.5 6.5 0 0 1 19 8.5a7.16 7.16 0 0 1-1.09 3.76" />
	<path d="M8.81 3.15A6.5 6.5 0 0 1 17.85 12.19c0 1.63-.44 2.81-1.09 3.76" />

	<path d="M8.8 20v-4.1l1.9.2a2.3 2.3 0 0 0 2.164-2.1l.036-5.7A5.37 5.37 0 0 0 2 8.25c0 2.8.656 3.054 1 4.55a5.77 5.77 0 0 1 .029 2.758L2 20" />
	<path d="M9 20v-4.44c1 .37 2.15.7 3 .07a2.5 2.5 0 0 0 1-2V8.5a5.5 5.5 0 1 0-11 0c0 2.8.66 2.8 1 4.3.23.9.24 1.85.03 2.76L2 20" />

		<path d="m4.9 4.9 1.4 1.4" />
		<path d="m17.7 17.7 1.4 1.4" />

		<path d="m6.3 17.7-1.4 1.4" />
		<path d="m19.1 4.9-1.4 1.4" />

feat: optimized accessibility icons #1574

feat: optimized accessibility icons #1574

Conversation

jguddas commented Sep 23, 2023

github-actions bot commented Sep 23, 2023 • edited Loading

Added or changed icons

jguddas commented Sep 23, 2023

ericfennis commented Sep 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2023

karsa-mistmere commented Nov 13, 2023

jguddas commented Nov 13, 2023

github-actions bot commented Sep 23, 2023 •

edited

Loading