Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): lucide-ize send icons #2346

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Bug fix

Description

Adds rounding to send icons.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

Added or changed icons

icons/send-horizontal.svgicons/send.svg

Preview cohesion icons/square-divide.svgicons/square-parking.svg
icons/send-horizontal.svgicons/send.svg
icons/key.svgicons/step-back.svg
Preview stroke widths icons/send-horizontal.svgicons/send.svg
icons/send-horizontal.svgicons/send.svg
icons/send-horizontal.svgicons/send.svg
DPI Preview (24px) icons/send-horizontal.svg icons/send.svg
Icon X-rays icons/send-horizontal.svg icons/send.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SendHorizontalIcon = createLucideIcon('SendHorizontal', [
  ["path",{"d":"M3.714 3.048a.498.498 0 0 0-.683.627l2.843 7.627a2 2 0 0 1 0 1.396l-2.842 7.627a.498.498 0 0 0 .682.627l18-8.5a.5.5 0 0 0 0-.904z"}],
  ["path",{"d":"M6 12h16"}]
])

const SendIcon = createLucideIcon('Send', [
  ["path",{"d":"M14.536 21.686a.5.5 0 0 0 .937-.024l6.5-19a.496.496 0 0 0-.635-.635l-19 6.5a.5.5 0 0 0-.024.937l7.93 3.18a2 2 0 0 1 1.112 1.11z"}],
  ["path",{"d":"m21.854 2.147-10.94 10.939"}]
])

@jguddas
Copy link
Member

jguddas commented Jul 31, 2024

This feels consistent, I feel like we should arcify everything, including things that are arrowy.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 31, 2024
@jguddas jguddas changed the title fix(): Lucide-ize send icons fix(icons): lucide-ize send icons Aug 31, 2024
@karsa-mistmere karsa-mistmere merged commit efcede6 into main Aug 31, 2024
8 checks passed
@karsa-mistmere karsa-mistmere deleted the icon-fix/send-rounding branch August 31, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants