Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed cuboid icon #2684

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Dec 10, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Arcified corner and added some metadata.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Dec 10, 2024
Copy link

Added or changed icons

icons/cuboid.svg

Preview cohesion icons/square-radical.svg
icons/cuboid.svg
icons/siren.svg
Preview stroke widths icons/cuboid.svg
icons/cuboid.svg
icons/cuboid.svg
DPI Preview (24px) icons/cuboid.svg
Icon X-rays icons/cuboid.svg
Icon Diffs icons/cuboid.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CuboidIcon = createLucideIcon('Cuboid', [
  ["path",{"d":"M 10 22 L 10 13.65"}],
  ["path",{"d":"M15.07 2.34a2 2 0 0 0-2.17-.05L2.95 8.41a2 2 0 0 0-.95 1.7v5.82a2 2 0 0 0 .88 1.66l6.05 4.07a2 2 0 0 0 2.17.05l9.95-6.12a2 2 0 0 0 .95-1.7V8.06a2 2 0 0 0-.88-1.66z"}],
  ["path",{"d":"m21.77 7.13-10.724 6.22a2 2 0 0 1-2.17-.05L2.25 9.15"}]
])

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Dec 10, 2024

Not sure about arcing those arcs, should we do that we might as well add arcs to box, but we don't, if we did, maybe something like this would be a better approach? (i.e. arcing the top plane and "extruding it", this is for box, but the same principles could be applied to cuboid).

But I think all in all I prefer our current box as it is, so I would prefer cuboid to remain consistent.

icons
Open lucide studio

@jguddas
Copy link
Member Author

jguddas commented Dec 10, 2024

I think we should arcify the box, package for example already has a round corner.

Package also has a non parallel line btw.

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Dec 10, 2024

I think we should arcify the box, package for example already has a round corner.

Package also has a non parallel line btw.

iconsOpen lucide studio

Already not a huge fan of that package, I'm afraid. 😅

If you overlay it on itself it's just all over the place, the middle line is the least of our troubles:
image

Correlate this with box:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants