Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World map #173

Closed
Closed

Conversation

ankit-singhaniya
Copy link
Contributor

Hi,
@chrismattmann

I am proposing the following two modifications (Feature Addition) to the existing Map Panel in Banana.

Adding Antarctica to the World Map.

Description: The jVectorMap of "world" in Banana does not have the Antarctic region. Reason might be that the jVectorMap of the world only plots countries. But Antarctica as an Continent can add value to the existing world map for Data Visualization in Banana.
Approach: Linearly scaled jVectorMap Coordinates for Antarctica (standards) to target map size.

original map panel
Fig. 1: Original Map Panel

modified world map added antarctica
Fig. 2: Modified Panel With Antarctica Region

Adding Capability of Finding Country by Country Names

Description: The Map panel by default needs a solr field that has Country Codes (US, IN, etc) and thus this makes it **difficult to use* the panel on any other fields of indexed text.*
One problem in using it in normal text is that few codes are frequently found English text like "IN" meaning "inside" and not "India".
Solution: (Optional) choice to use Country Names than using Country Codes (default) for Finding Countries in the Solr Field.
Approach: Maps Country Names given the list of Countries on the World Map to corresponding Codes (that jVectorMap uses to plot).

modified panel option visible for world map selection
Fig 1: Modified Panel Settings Page Showing Option to use Country Names for "World Map"

modified panel option hidden for europe other than world map selection
Fig. 2: Modified Panel Settings Page Hiding the Option of using Country Names for any other map than "World" Map

original world map panel settings
Fig. 3: Original Panel Settings Page

@chrismattmann
Copy link

very cool we need this on my NSF Polar CyberInfrastructure work thanks @ankit-singhaniya !

@chrismattmann
Copy link

ping, can someone take a look at this? It's preventing me from using Banana in my polar work for the NSF.

@chrismattmann
Copy link

thanks to my USC students for these contributions.

@athana
Copy link
Contributor

athana commented Jul 27, 2015

Thanks @ankit-singhaniya for your contributions! I'm truly appreciated. @chrismattmann I'm sorry for the delay. I will work on merging these contributions into the develop branch first, so you can try it while waiting for the next Banana release.

@athana athana self-assigned this Jul 27, 2015
@athana athana added this to the 1.6.0 milestone Jul 27, 2015
@chrismattmann
Copy link

thanks @athana really appreciate it man! we really like Banana and the work you've all been doing is fantastic. Keep it up. I'll keep teaching it in my CS572 Search Engines graduate course at USC :) http://sunset.usc.edu/classes/cs572_2015/

@athana
Copy link
Contributor

athana commented Aug 6, 2015

@ankit-singhaniya @chrismattmann there's a bug in this PR. When I used the "Country Names" mode in the world map, and then I clicked on a country (for example, Canada) to add a filter. It does not work properly because the filter value will be the country code value (CA for Canada), instead of the full country name. I will have to fix this before I merge it to develop branch.

@chrismattmann
Copy link

thanks @athana good catch. Do you need me/us to update, or do you got this one?

@athana
Copy link
Contributor

athana commented Aug 12, 2015

@chrismattmann I got this one. thanks.

@athana
Copy link
Contributor

athana commented Aug 17, 2015

@chrismattmann @ankit-singhaniya I fixed the bug and modified a few things. I separated the world maps into two maps: the original world map and the world-antarctica map. You guys can check it out in the develop branch (commit 6d07515)

@athana athana closed this Aug 17, 2015
@chrismattmann
Copy link

awesome job @athana thank you so much! great job @ankit-singhaniya !

@ankit-singhaniya
Copy link
Contributor Author

Thanks @athana for the quick fix, thanks @chrismattmann for following this
up. I am happy to have contributed this.

On Mon, Aug 17, 2015 at 9:57 AM, Chris Mattmann notifications@github.com
wrote:

awesome job @athana https://github.com/athana thank you so much! great
job @ankit-singhaniya https://github.com/ankit-singhaniya !


Reply to this email directly or view it on GitHub
#173 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants