Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validation for special phone numbers #19

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fixed validation for special phone numbers #19

merged 1 commit into from
Oct 6, 2022

Conversation

luciferreeves
Copy link
Owner

Fixes #16

@luciferreeves luciferreeves linked an issue Oct 6, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #19 (f79c2e8) into main (155f249) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          926       927    +1     
  Branches        86        86           
=========================================
+ Hits           926       927    +1     
Impacted Files Coverage Δ
tests/test_phone.py 100.00% <ø> (ø)
src/edify/library/phone.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luciferreeves luciferreeves merged commit 3dfdd67 into main Oct 6, 2022
@luciferreeves luciferreeves deleted the fix-16 branch October 6, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone pattern fails for service numbers and 4 digit numbers
1 participant