Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty media tag attributes makes media non-playable. #14

Closed
kabalin opened this issue Nov 13, 2019 · 2 comments
Closed

Empty media tag attributes makes media non-playable. #14

kabalin opened this issue Nov 13, 2019 · 2 comments
Labels
bug

Comments

@kabalin
Copy link
Contributor

kabalin commented Nov 13, 2019

Currently media tag specific attributes with empty values results in imposibility to play video without obvious error output.

<video width="720" height="480" controls="" loop="" title=""><source src="http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4">http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4</video>
@kabalin
Copy link
Contributor Author

kabalin commented Nov 13, 2019

As the spec permits using these tags without value provided, they simply need to be set to "true" so when they are propagated to setup settings, JW7 player is not getting confused.

kabalin added a commit that referenced this issue Nov 13, 2019
@kabalin
Fix empty media tag unplayable media issie (#14).
6455be5
kabalin added a commit that referenced this issue Nov 13, 2019
@kabalin
Fix empty media tag unplayable media issie (#14).
52c12ca
kabalin added a commit that referenced this issue Nov 13, 2019
@kabalin
Fix empty media tag causes unplayable media issue (#14).
f476fef
@kabalin kabalin added the bug label Nov 13, 2019
@kabalin kabalin closed this as completed Nov 22, 2019
@kabalin
Copy link
Contributor Author

kabalin commented Nov 22, 2019

Fixed in 7-0.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kabalin