Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: make title optional #8

Merged
merged 2 commits into from
May 18, 2018

Conversation

jproctor
Copy link
Contributor

This branch assumes PR #7 was accepted.

Currently, if there is no title attribute in the player link, the plugin displays the filename as the title. I have a lot of existing auto-generated links with no title attribute and filename “playlist.m3u8”, which I do not want to present to users.

This branch adds a setting emptytitle (“Allow empty title”, Default: No) which, if enabled, skips the filename substitution described above.

Adding a new setting obviously requires a version number increase, but I did not include that in the commit.

@kabalin kabalin merged commit 46668e0 into lucisgit:master May 18, 2018
@kabalin
Copy link
Contributor

kabalin commented May 18, 2018

Heh, I thought it will not list previous commit on the branch since the code is identical to what has been merged in #7. Well, never mind, something to know. Thanks for contributing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants