result_timeout kwarg for all Sender functions

[luckydonald]

fixes #48 ?
@the-glu can you test that, please?

[the-glu]

Well, it will work in "my" case, but doesn't allow to override the timeout if the default one is used.
The comment is also wrong since you copy-pasted it from my PR who allow it.

Why a new pull request ? I can fix #48 ;)

[luckydonald]

This was what I did briefly in the online editor. But you shouldn't want use the default timeout, if you specify your own?

[the-glu]

I don't understand :)

I don't think the default timeout should be used, I a custom is specified.

[luckydonald]

Well, it will work in "my" case, but doesn't allow to override the timeout if the default one is used.

The default one is only used when you don't override it, and t.
Why do you need to change only the default?

Can you tell me step by step, what you are trying to archive?
Maybe when I understand, I can help you correctly.

[the-glu]

I want to be able to set the timeout at a provided value in all cases (if there is a timeout set in functions definitions or the default one is used) . That what I did in #48 .

[luckydonald]

I believe that is possible here too, with actual less code.
I really can't see any difference. You assign just a second variable for something already possible with result_timeout?

result_timeout = functions[function_name][FUNC_TIME]  #moved upwards
if "result_timeout" in kwargs:
    result_timeout = kwargs["result_timeout"]  # overrides functions[...][FUNC_TIME]
self._do_command( ... , answer_timeout=result_timeout , ...)

That should be equivalent to your version:

custom_timeout = None
 if "custom_timeout" in kwargs:
    custom_timeout = kwargs["custom_timeout"]
result_timeout = functions[function_name][FUNC_TIME]

self._do_command( ... , answer_timeout=result_timeout if custom_timeout is None else custom_timeout , ...)
# overrides functions[...][FUNC_TIME] aka. result_timeout 

except for the kwarg name of course.

[luckydonald]

Actually, in your version I cannot set it to None explicitly.

[luckydonald]

If you see a case the code above doesn't handle please tell me.
And thanks again for your code.
closes #48