Rename Form -> SaveOperation #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
force-pushed
the
pcs/make-avram-forms-better
branch
from
9d45607 to
9083fa7
Compare
paulcsmith
added a commit
to luckyframework/lucky
that referenced
this pull request
Jun 15, 2019
5 tasks
paulcsmith
added a commit
to luckyframework/lucky
that referenced
this pull request
Jun 15, 2019
paulcsmith
added a commit
to luckyframework/lucky_cli
that referenced
this pull request
Jun 15, 2019
paulcsmith
added a commit
to luckyframework/lucky_cli
that referenced
this pull request
Jun 15, 2019
paulcsmith
pushed a commit
to luckyframework/lucky_cli
that referenced
this pull request
Jun 20, 2019
* Rename Form -> SaveOperation Part of luckyframework/avram#104 * Update the app skeleton to use 'permit_columns' instead of 'fillable' * Update the app skeleton to use 'Avram::PermittedAttribute' instead of 'Avram::FillableField'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
This will require changes to LuckyCLI and Lucky. We can merge this then fix those
These changes are big so rather than deprecating and maintaining tons of code for a release or two, I think we need to pull off the bandaid and make the switch. It's mostly renaming so I think this should be easy for people to upgrade anyway