Adding in a new after_completed callback #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432
Also see comment: #481 (comment)
This is a new callback added for SaveOperation that will run after commits, but this also runs even if no changes are happening to the record. As where
after_commitonly runs if an actual DB commit happens,after_completedwill run even when there's no changes to be made.Naming is hard, so I'm down for a different name. I also thought about calling it
after_finalizedorafter_succesful_run.Another option I toyed with was doing
after_validated; however, I felt that a name like that would imply that it would run after thevalid?calls... This would allow us to call in both spots, but the original issue for #432 wanted to run things after stuff was saved, and that would not be the case here 🤔