Add any? and none? as query methods #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcgarvey
commented
Jul 10, 2021
Comment on lines
+77
to
+82
| {% for crystal_db_alias in [:exec, :scalar, :query, :query_all, :query_one, :query_one?, :query_each] %} | ||
| # Same as crystal-db's `DB::QueryMethods#{{ crystal_db_alias.id }}` but with instrumentation | ||
| def {{ crystal_db_alias.id }}(query, *args_, args : Array? = nil, queryable : String? = nil, **named_args) | ||
| publish_query_event(query, args_, args, queryable) do | ||
| run do |db| | ||
| db.{{ crystal_db_alias.id }}(query, *args_, args: args) | ||
| db.{{ crystal_db_alias.id }}(query, *args_, **named_args, args: args) |
There was a problem hiding this comment.
Because we haven't used them before in the codebase, there was a bug here that meant we couldn't call query_all or query_one and the added query_one?. It expects an as named argument that passes in what it should be converted into
jwoertink
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
Sweet! This is a pretty nice method. It seems like it would actually run faster than doing .first? checks. Out of curiosity, have you tried any benchmarks?
Kind of a bummer we will have to start disabling the ameba checks around this, but I get it.
This all looks good 👍
|
Ran a benchmark comparing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #680
Provides two simple methods to check if there are any records in the database matching the specified conditions. Within avram's codebase, it simplifies the uniqueness checks.
Usage looks like: