Add optional lucky extensions for avram #772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where the code that combines Lucky and Avram will live that was taken from luckyframework/lucky#1620.
To get the same behavior in apps as there was before, requires will be changed.
becomes
That should be the only breaking change. The tasks should continue to work, but the ones removed from lucky will no longer be preloaded (
lucky gen.model
andlucky gen.resource.browser
)I organized the code in a way that Avram can be run without the lucky dependency if desired. For instance, lucky is not included as a dependency of Avram (it is a development dependency, though). So, in order to use
require "avram/lucky"
, you must add lucky as a dependency or use in a lucky app.