Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beef up responsive meta tag #828

Closed
jwoertink opened this issue Jun 25, 2019 · 2 comments · Fixed by #835
Closed

Beef up responsive meta tag #828

jwoertink opened this issue Jun 25, 2019 · 2 comments · Fixed by #835
Labels
feature request A new requested feature / option good first issue Good for newcomers

Comments

@jwoertink
Copy link
Member

We have this cool method

https://github.com/luckyframework/lucky/blob/master/src/lucky/tags/specialty_tags.cr#L40

But the viewport meta tag has a lot more options. We should have this method take some options to update things like user-scalable, minimum-scale, and maximum-scale.
@jwoertink jwoertink added good first issue Good for newcomers feature request A new requested feature / option labels Jun 25, 2019
@smadeja
Copy link
Contributor

smadeja commented Jun 30, 2019

I've created this little draft. What do you think?

@jwoertink
Copy link
Member Author

That looks good @smadeja. You can submit the PR and we can look over it. Thanks!

@smadeja smadeja mentioned this issue Jul 1, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request A new requested feature / option good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft the beefed up responsive meta tag
2 participants
@jwoertink @smadeja