Draft the beefed up responsive meta tag #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
reviewed
Jul 1, 2019
src/lucky/tags/specialty_tags.cr
Outdated
| @@ -74,4 +75,14 @@ module Lucky::SpecialtyTags | |||
| how_many.times { raw(" ") } | |||
| view | |||
| end | |||
|
|
|||
| private def build_content_attr_value(options) | |||
There was a problem hiding this comment.
Could you name this something like build_responsive_meta_tag_content_attr. So that it is clear it is for the responsive_meta_tag? We may need something like this in the future for other methods, but until then I think being specific will add clarity
There was a problem hiding this comment.
Would build_viewport_properties be ok? If so, then I think it's ready.
jwoertink
requested changes
Jul 1, 2019
smadeja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #828. The docs will have to be updated, I wanted to get some feedback first.
Checklist
crystal tool format spec src./script/setup./script/test