Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes @ from various page templates #1236

Merged
merged 1 commit into from
Aug 14, 2020
Merged

removes @ from various page templates #1236

merged 1 commit into from
Aug 14, 2020

Conversation

mwlang
Copy link
Contributor

@mwlang mwlang commented Aug 14, 2020 •
edited
Loading

Purpose

removes @ from various page templates

Description

See #1230

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

paulcsmith
paulcsmith approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @mwlang

@paulcsmith paulcsmith merged commit 7e0df87 into luckyframework:master Aug 14, 2020
@matthewmcgarvey matthewmcgarvey mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwlang @paulcsmith