Fix passing UUID to tags #1280
Merged
Fix passing UUID to tags #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Oct 13, 2020
There was a problem hiding this comment.
Hey, thanks for submitting this! Though, I'm not too sure about it. None of the tags allow for anything aside from String as the inner text. I do agree that if you're using UUID, some of the things are a little funky. I made a small suggestion.
Can you give that a shot and see if the specs all pass that way? If so, then we will just do that and remove the overload.
|
Thanks for catching this @wontruefree! |
|
@jwoertink Thanks for updating the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using UUID as a primary key there are some scaffolds that do not work.
Description
This adds a helper that makes it so the scaffolds work with a UUID. I could add to_s to the text but I dont know if adding an extra call is what would be best for a generic helper.